[
https://issues.apache.org/jira/browse/KAFKA-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010091#comment-17010091
]
ASF GitHub Bot commented on KAFKA-9380:
---------------------------------------
belugabehr commented on pull request #7905: KAFKA-9380: Do Not Accept Null
Values in MemberAssignment Constructor
URL: https://github.com/apache/kafka/pull/7905
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Do Not Accept Null Values in MemberAssignment Constructor
> ---------------------------------------------------------
>
> Key: KAFKA-9380
> URL: https://issues.apache.org/jira/browse/KAFKA-9380
> Project: Kafka
> Issue Type: Improvement
> Reporter: David Mollitor
> Priority: Minor
>
> 'nulls suck'
> [https://github.com/google/guava/wiki/UsingAndAvoidingNullExplained]
> Just exit quickly if a null is passed into MemberAssignment Constructor. No
> need to check for null values. I've looked at all references and they
> correctly pass in an empty Collection instead of null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
