[ https://issues.apache.org/jira/browse/KAFKA-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manikumar resolved KAFKA-3620. ------------------------------ Resolution: Fixed Closing this as some cleanup done in newer versions. Please reopen if you think otherwise. > Clean up Protocol class. > ------------------------ > > Key: KAFKA-3620 > URL: https://issues.apache.org/jira/browse/KAFKA-3620 > Project: Kafka > Issue Type: Improvement > Reporter: Ashish Singh > Assignee: Ashish Singh > Priority: Major > > This came up on PR of KAFKA-3307. Below is excerpt. > {quote} > With the versioning getting a little more complex in Protocol class, it makes > sense to try and encapsulate some of its logic a little better. For example, > rather than using raw arrays for each request type, we could have something > like this: > {code} > class KafkaApi { > private ApiKey api; > private Schema[] requests; > private Schema[] responses; > Schema currentSchema(); > Schema schemaFor(int version); > int minVersion(); > int currentVersion(); > } > {code} > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)