[ 
https://issues.apache.org/jira/browse/KAFKA-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Kim updated KAFKA-12264:
-----------------------------
    Description: 
Classes that extend BaseRecordBatchBenchmark cannot run with (compression type 
= ZSTD, magic number = 1). The classes are the following:

CompressedRecordBatchValidationBenchmark
 RecordBatchIterationBenchmark

Error shows:
 [2021-01-26T01:05:11.229Z] # Run progress: 10.03% complete, ETA 1 days, 
03:39:45
 [2021-01-26T01:05:11.229Z] # Fork: 1 of 1
 [2021-01-26T01:05:11.229Z] # Warmup Iteration 1: <failure>
 [2021-01-26T01:05:11.229Z] 
 [2021-01-26T01:05:11.229Z] java.lang.IllegalArgumentException: ZStandard 
compression is not supported for magic 1
  

Move messageVersion into subclasses and override messageVersion() like we do 
for compressionType. Create a separate subclass for each of the two subclasses 
to handle ZSTD,magic 2 

  was:
Classes that extend BaseRecordBatchBenchmark cannot run with (compression type 
= ZSTD, magic number = 1). The classes are the following:



CompressedRecordBatchValidationBenchmark
RecordBatchIterationBenchmark

Error shows:
[2021-01-26T01:05:11.229Z] # Run progress: 10.03% complete, ETA 1 days, 03:39:45
[2021-01-26T01:05:11.229Z] # Fork: 1 of 1
[2021-01-26T01:05:11.229Z] # Warmup Iteration   1: <failure>
[2021-01-26T01:05:11.229Z] 
[2021-01-26T01:05:11.229Z] java.lang.IllegalArgumentException: ZStandard 
compression is not supported for magic 1
 

Proposal is to move all fields and methods from BaseRecordBatchBenchmark to 
individual subclasses. This will increase make each subclass more verbose. This 
is required as compression type cannot be passed from subclass to parent class.


> JMH BaseRecordBatchBenchmark ZSTD error
> ---------------------------------------
>
>                 Key: KAFKA-12264
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12264
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jeff Kim
>            Assignee: Jeff Kim
>            Priority: Minor
>
> Classes that extend BaseRecordBatchBenchmark cannot run with (compression 
> type = ZSTD, magic number = 1). The classes are the following:
> CompressedRecordBatchValidationBenchmark
>  RecordBatchIterationBenchmark
> Error shows:
>  [2021-01-26T01:05:11.229Z] # Run progress: 10.03% complete, ETA 1 days, 
> 03:39:45
>  [2021-01-26T01:05:11.229Z] # Fork: 1 of 1
>  [2021-01-26T01:05:11.229Z] # Warmup Iteration 1: <failure>
>  [2021-01-26T01:05:11.229Z] 
>  [2021-01-26T01:05:11.229Z] java.lang.IllegalArgumentException: ZStandard 
> compression is not supported for magic 1
>   
> Move messageVersion into subclasses and override messageVersion() like we do 
> for compressionType. Create a separate subclass for each of the two 
> subclasses to handle ZSTD,magic 2 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to