[ 
https://issues.apache.org/jira/browse/KAFKA-7819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanislav Kozlovski updated KAFKA-7819:
---------------------------------------
    Description: 
Trogdor's RoundTripWorker task has a couple of shortcomings:
 * Consumer GroupID is hardcoded and consumers use `KafkaConsumer#assign()`: 
[https://github.com/apache/kafka/blob/12947f4f944955240fd14ce8b75fab5464ea6808/tools/src/main/java/org/apache/kafka/trogdor/workload/RoundTripWorker.java#L314]

Leaving you unable to run two separate instances of this worker on the same 
partition in the same cluster, as the consumers would overwrite each other's 
commits. It's probably better to add the task ID to the consumer group
 * the task spec's `maxMessages` [is an 
integer|https://github.com/apache/kafka/blob/12947f4f944955240fd14ce8b75fab5464ea6808/tools/src/main/java/org/apache/kafka/trogdor/workload/RoundTripWorkloadSpec.java#L39],
 leaving you unable to schedule long-winded tasks

  was:
Trogdor's RoundTripWorker task has a couple of shortcomings:
* Consumer GroupID is hardcoded and consumers use `KafkaConsumer#assign()`: 
[https://github.com/apache/kafka/blob/12947f4f944955240fd14ce8b75fab5464ea6808/tools/src/main/java/org/apache/kafka/trogdor/workload/RoundTripWorker.java#L314]

Leaving you unable to run two separate instances of this worker on the same 
partition in the same cluster, as the consumers would overwrite each other's 
commits. It's probably better to add the task ID to the consumer group

* the task spec's `maxMessages` [is an 
integer|https://github.com/apache/kafka/blob/12947f4f944955240fd14ce8b75fab5464ea6808/tools/src/main/java/org/apache/kafka/trogdor/workload/RoundTripWorkloadSpec.java#L39],
 leaving you unable to schedule long-winded tasks

* the consumer and producer are not closed gracefully when the task ends


> Trogdor - Improve RoundTripWorker
> ---------------------------------
>
>                 Key: KAFKA-7819
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7819
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Stanislav Kozlovski
>            Assignee: Stanislav Kozlovski
>            Priority: Minor
>
> Trogdor's RoundTripWorker task has a couple of shortcomings:
>  * Consumer GroupID is hardcoded and consumers use `KafkaConsumer#assign()`: 
> [https://github.com/apache/kafka/blob/12947f4f944955240fd14ce8b75fab5464ea6808/tools/src/main/java/org/apache/kafka/trogdor/workload/RoundTripWorker.java#L314]
> Leaving you unable to run two separate instances of this worker on the same 
> partition in the same cluster, as the consumers would overwrite each other's 
> commits. It's probably better to add the task ID to the consumer group
>  * the task spec's `maxMessages` [is an 
> integer|https://github.com/apache/kafka/blob/12947f4f944955240fd14ce8b75fab5464ea6808/tools/src/main/java/org/apache/kafka/trogdor/workload/RoundTripWorkloadSpec.java#L39],
>  leaving you unable to schedule long-winded tasks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to