Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-07 Thread via GitHub
cadonna merged PR #15870: URL: https://github.com/apache/kafka/pull/15870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-07 Thread via GitHub
lucasbru commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591960681 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591277510 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591262531 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1421,15 +1422,20 @@ public void

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591261680 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591223152 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591216607 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591204696 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591204373 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591198311 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -71,6 +73,10 @@ import static

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591121181 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna closed pull request #15867: KAFKA-10199: Remove lost tasks in state updater with new remove URL: https://github.com/apache/kafka/pull/15867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to