Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1982991126 @chia7712 Thanks for the review and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

chia7712 commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1982054671 @nizhikov thanks for this nice patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

chia7712 merged PR #15363: URL: https://github.com/apache/kafka/pull/15363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

chia7712 commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1982051350 the failed tests pass on my machine. ```sh ./gradlew cleanTest core:test --tests ReplicaManagerTest --tests LogDirFailureTest ``` will merge it -- This is an automated mess

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1981384111 @nizhikov Thanks for the review. All your comments fixed. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514833400 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -0,0 +1,840 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514832937 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -0,0 +1,840 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

chia7712 commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514645806 ## tools/src/test/java/org/apache/kafka/tools/ToolsTestUtils.java: ## @@ -210,6 +212,29 @@ public static File tempPropertiesFile(Map properties) throws IOE r

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514391934 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514388497 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

chia7712 commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514369281 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

chia7712 commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514366938 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1980469311 @chia7712 This PR ready for review. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1976786020 @chia7712 Other PR is #15465 Seems, PR's are reviewable now. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-14589 [2/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

nizhikov commented on PR #15363: URL: https://github.com/apache/kafka/pull/15363#issuecomment-1976763803 @chia7712 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To