Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-23 Thread via GitHub
ableegoldman commented on PR #15972: URL: https://github.com/apache/kafka/pull/15972#issuecomment-2127918475 Yep, just noticed this. Sorry about that. We're taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-22 Thread via GitHub
dajac commented on PR #15972: URL: https://github.com/apache/kafka/pull/15972#issuecomment-2126312436 Hey @ableegoldman @apourchet, I see new failures in trunk that seems to be related to this PR. The last build of this PR had 100+ failures: https://ci-builds.apache.org/blue/organizations/j

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-22 Thread via GitHub
ableegoldman merged PR #15972: URL: https://github.com/apache/kafka/pull/15972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-20 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1607404895 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -1974,6 +1974,15 @@ public Set nonSourceChangelogTopics(

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-20 Thread via GitHub
apourchet commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1606917357 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackUtils.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-20 Thread via GitHub
apourchet commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1606917357 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackUtils.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-20 Thread via GitHub
apourchet commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1606913055 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackUtils.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-17 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1605660608 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -472,23 +482,74 @@ public GroupAssignment assign(final C

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-17 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1605659907 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -472,23 +482,74 @@ public GroupAssignment assign(final C

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-17 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1605659120 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -472,23 +482,74 @@ public GroupAssignment assign(final C

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-17 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1605656530 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -472,23 +482,74 @@ public GroupAssignment assign(final C

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-17 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1605639072 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -472,23 +482,74 @@ public GroupAssignment assign(final C

Re: [PR] KAFKA-15045: (KIP-924 pt. 5) Add rack information to ApplicationState [kafka]

2024-05-16 Thread via GitHub
ableegoldman commented on code in PR #15972: URL: https://github.com/apache/kafka/pull/15972#discussion_r1604122125 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/DefaultTaskInfo.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software