C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1360796008
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
C0urante merged PR #14538:
URL: https://github.com/apache/kafka/pull/14538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on PR #14538:
URL: https://github.com/apache/kafka/pull/14538#issuecomment-177221
Thanks for the reviews, all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364507968
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol, me
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364507968
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol, me
gharris1727 commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364474243
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
gharris1727 commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364457214
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol,
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362527136
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java:
##
@@ -72,115 +41,42 @@
import static
org.apache.kafka.connect.r
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362530005
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java:
##
@@ -332,722 +186,46 @@ public Set workers() {
return n
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362528851
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java:
##
@@ -302,27 +177,6 @@ public String getName() {
return
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362527738
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java:
##
@@ -225,28 +121,6 @@ public void removeWorker(WorkerHandle work
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362527136
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java:
##
@@ -72,115 +41,42 @@
import static
org.apache.kafka.connect.r
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362238029
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/StandaloneWorkerTest.java:
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundatio
yashmayya commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362109618
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/StandaloneWorkerTest.java:
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundati
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1360904810
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol, me
yashmayya commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1362100106
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConfigBackingStore.java:
##
@@ -164,6 +171,13 @@ interface UpdateListener {
* @param resta
C0urante commented on PR #14538:
URL: https://github.com/apache/kafka/pull/14538#issuecomment-1764882825
Ah, never mind--I realize that some static fields for timeouts from the
`EmbeddedConnectClusterAssertions` class may be used in downstream projects.
I've pushed a new commit with the sug
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1360788058
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1360768631
##
checkstyle/suppressions.xml:
##
@@ -139,6 +139,8 @@
files="Worker(SinkTask|SourceTask|Coordinator).java"/>
+
Review Comment:
Switching
yashmayya commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1360494846
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
gharris1727 commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1358597074
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
yangy commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1357785014
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
yangy commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1357779469
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
gharris1727 commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1357258143
##
checkstyle/suppressions.xml:
##
@@ -139,6 +139,8 @@
files="Worker(SinkTask|SourceTask|Coordinator).java"/>
+
Review Comment:
nit: we
C0urante commented on PR #14538:
URL: https://github.com/apache/kafka/pull/14538#issuecomment-1760004960
@gharris1727, @yashmayya, @mimaison would any of you be able to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
25 matches
Mail list logo
