showuon merged PR #14511:
URL: https://github.com/apache/kafka/pull/14511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #14511:
URL: https://github.com/apache/kafka/pull/14511#issuecomment-1763872414
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTest.shouldHaveSamePositionBoundActiveAndStandBy
showuon commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1360211831
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -525,7 +525,7 @@ class RemoteIndexCacheTest {
.filter(path => path.getFileName
showuon commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1360207445
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -525,7 +525,7 @@ class RemoteIndexCacheTest {
.filter(path => path.getFileName
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460675
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460627
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460606
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460521
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359435180
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -525,7 +525,7 @@ class RemoteIndexCacheTest {
.filter(path => path.getFileName.
showuon commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1358195654
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().est
showuon commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1358164148
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().est
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1358013056
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,103 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1358012358
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,103 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
satishd commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1357974980
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,103 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().est
satishd commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1357784736
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,103 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().est
divijvaidya commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1356830611
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -137,15 +138,8 @@ public RemoteIndexCache(long maxSize, RemoteStorageMa
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1355219802
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -716,4 +710,8 @@ public static String
remoteTransactionIndexFileName(Remote
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1355175100
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -137,15 +138,8 @@ public RemoteIndexCache(long maxSize, RemoteStorageManager
divijvaidya commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1352082129
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -137,15 +138,8 @@ public RemoteIndexCache(long maxSize, RemoteStorageMa
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1349931016
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -554,6 +554,115 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1349931417
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -554,6 +554,115 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().esti
kamalcph commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1349882603
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -554,6 +554,115 @@ class RemoteIndexCacheTest {
assertTrue(cache.internalCache().es
22 matches
Mail list logo
