Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

ijuma commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1488353336 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1488290251 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

ijuma commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1488125293 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

ijuma commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1488125293 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan merged PR #15324: URL: https://github.com/apache/kafka/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jeqo commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1936481385 @jolshan thanks for catching this! adding it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1936317088 Hey there @jeqo looks like check style failed. Do you mind adding the apache header to your new benchmark?

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jeqo commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483676179 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java: ## @@ -0,0 +1,82 @@ +package org.apache.kafka.jmh.storage; + +import

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483652492 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java: ## @@ -0,0 +1,82 @@ +package org.apache.kafka.jmh.storage; + +import

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483650845 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java: ## @@ -0,0 +1,82 @@ +package org.apache.kafka.jmh.storage; + +import

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483649564 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jeqo commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1482430278 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1482140038 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1932990160 Also @jeqo -- just curious which java version were you running? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jeqo commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1932429115 @jolshan sure! I just added it  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

jolshan commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1930479050 Hey @jeqo thanks for taking a look and improving this area! Can we add the benchmarks from the ticket to the PR description? -- This is an automated message from the Apache Git