Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-07 Thread via GitHub
mimaison merged PR #15457: URL: https://github.com/apache/kafka/pull/15457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-06 Thread via GitHub
wernerdv commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1514997085 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java: ## @@ -322,6 +324,20 @@ private void invalidOffset(String offset) {

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-06 Thread via GitHub
mimaison commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1514959532 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java: ## @@ -322,6 +324,20 @@ private void invalidOffset(String offset) {

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-06 Thread via GitHub
wernerdv commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1514949575 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { } publi

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-06 Thread via GitHub
mimaison commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1514821883 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { } publi

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-06 Thread via GitHub
wernerdv commented on PR #15457: URL: https://github.com/apache/kafka/pull/15457#issuecomment-1980452029 Hello, @mimaison Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-04 Thread via GitHub
wernerdv commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1511460897 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { } publi

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-04 Thread via GitHub
OmniaGM commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1510981252 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { } public

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-04 Thread via GitHub
OmniaGM commented on code in PR #15457: URL: https://github.com/apache/kafka/pull/15457#discussion_r1510969600 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) { } public

Re: [PR] KAFKA-16246: Cleanups in ConsoleConsumer [kafka]

2024-03-02 Thread via GitHub
wernerdv commented on PR #15457: URL: https://github.com/apache/kafka/pull/15457#issuecomment-1975051194 Hello, @mimaison @OmniaGM Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t