ahuang98 commented on PR #16160:
URL: https://github.com/apache/kafka/pull/16160#issuecomment-2148481736
Yeah looks like those are existing failures. Looks like Jose didn't take any
of the changes, closing this out.
--
This is an automated message from the Apache Git Service.
To respond t
ahuang98 closed pull request #16160: KAFKA-16252: Dynamic KRaft network manager
and channel
URL: https://github.com/apache/kafka/pull/16160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
cmccabe commented on PR #16160:
URL: https://github.com/apache/kafka/pull/16160#issuecomment-2143980581
There are some test failures in `KafkaRaftClientTest`and `StorageToolTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
showuon commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1620608088
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -17,108 +17,296 @@
package org.apache.kafka.raft;
import java.util.ArrayList;
+import java.ut
showuon commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1620562119
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -17,108 +17,296 @@
package org.apache.kafka.raft;
import java.util.ArrayList;
+import java.ut
cmccabe commented on PR #15986:
URL: https://github.com/apache/kafka/pull/15986#issuecomment-2138338743
Thanks for the PR, @jsancio . A few meta-comments:
- I'm not sure I see the benefit to changing the `toString` functions to use
`String.format`. It seems more brittle than the simpl
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619507872
##
raft/src/main/java/org/apache/kafka/raft/FollowerState.java:
##
@@ -156,22 +156,24 @@ public boolean canGrantVote(ReplicaKey candidateKey,
boolean isLogUpToDate) {
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619506788
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -21,12 +21,12 @@ import kafka.utils.{TestInfoUtils, TestUtils}
import org.apache.kafka.
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619520419
##
raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java:
##
@@ -55,15 +57,41 @@ final public class VoterSet {
}
/**
- * Returns the socket a
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619518236
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -17,108 +17,296 @@
package org.apache.kafka.raft;
import java.util.ArrayList;
+import java.ut
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619514531
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##
@@ -199,6 +206,34 @@ private static Map
parseVoterConnections(
return voterMap;
}
+
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619511561
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1635,24 +1693,29 @@ private Optional maybeHandleCommonResponse(
}
private void mayb
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619510911
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1593,6 +1644,13 @@ private Optional maybeHandleCommonResponse(
int epoch,
lon
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619507872
##
raft/src/main/java/org/apache/kafka/raft/FollowerState.java:
##
@@ -156,22 +156,24 @@ public boolean canGrantVote(ReplicaKey candidateKey,
boolean isLogUpToDate) {
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619506788
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -21,12 +21,12 @@ import kafka.utils.{TestInfoUtils, TestUtils}
import org.apache.kafka.
cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619506439
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -94,6 +95,7 @@ class SharedServer(
val time: Time,
private val _metrics: Metrics,
val controllerQ
jsancio commented on PR #15986:
URL: https://github.com/apache/kafka/pull/15986#issuecomment-2134135719
@hachikuji, thanks for the review. The PR is ready for another round.
The core of the issue that I fixed was that KRaft was sending two Fetch
requests for the same LEO. One of the F
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1615318177
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##
@@ -199,6 +206,34 @@ private static Map
parseVoterConnections(
return voterMap;
}
+
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1614958193
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -17,108 +17,196 @@
package org.apache.kafka.raft;
import java.util.ArrayList;
+import java.ut
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1610641974
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1366,6 +1368,26 @@ class KafkaConfigTest {
assertEquals(expectedVoters, addresses)
}
+
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1611947146
##
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##
@@ -118,6 +120,10 @@ class RaftManagerTest {
new Metrics(Time.SYSTEM),
Option.empty,
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1611946739
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##
@@ -231,4 +266,26 @@ public String toString() {
return "non-empty list";
}
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1611946424
##
raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java:
##
@@ -53,15 +56,41 @@ final public class VoterSet {
}
/**
- * Returns the socket a
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1611939749
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -393,17 +422,35 @@ public void initialize(
logger.info("Reading KRaft snapshot and log
jsancio commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1610641974
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1366,6 +1368,26 @@ class KafkaConfigTest {
assertEquals(expectedVoters, addresses)
}
+
hachikuji commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1610398594
##
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##
@@ -118,6 +120,10 @@ class RaftManagerTest {
new Metrics(Time.SYSTEM),
Option.empty,
26 matches
Mail list logo
