Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

mimaison commented on PR #15475: URL: https://github.com/apache/kafka/pull/15475#issuecomment-2218226588 None of the test failures seem related, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

mimaison merged PR #15475: URL: https://github.com/apache/kafka/pull/15475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

bachmanity1 commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1669346859 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void test

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

bachmanity1 commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1669337234 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void test

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

kirktrue commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1668868527 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void testPar

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

bachmanity1 commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1664248591 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void test

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

bachmanity1 commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1664244790 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void test

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

mimaison commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1663905062 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -192,6 +192,10 @@ public class SaslConfigs { + " be inspected for the stan

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

bachmanity1 commented on PR #15475: URL: https://github.com/apache/kafka/pull/15475#issuecomment-2079216075 Hi @mimaison, would you mind taking a look at the KIP and sharing your vote on it? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

kirktrue commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1529074359 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -192,6 +192,12 @@ public class SaslConfigs { + " be inspected for the stan

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

bachmanity1 commented on PR #15475: URL: https://github.com/apache/kafka/pull/15475#issuecomment-1989425275 @kirktrue @mimaison kind reminder. Could you please have a look at the KIP? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to