Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-26 Thread via GitHub
cmccabe merged PR #15584: URL: https://github.com/apache/kafka/pull/15584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
cmccabe commented on PR #15584: URL: https://github.com/apache/kafka/pull/15584#issuecomment-2018746846 > I don't think it's a good idea to introduce the new terms mangling & unmangling when there are already equivalent terms in the codebase – sanitizing/desanitizing – it makes it

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
cmccabe commented on code in PR #15584: URL: https://github.com/apache/kafka/pull/15584#discussion_r1538115580 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -50,44 +51,54 @@ class ZkConfigMigrationClient( val adminZkClient = new

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
cmccabe commented on code in PR #15584: URL: https://github.com/apache/kafka/pull/15584#discussion_r1538115580 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -50,44 +51,54 @@ class ZkConfigMigrationClient( val adminZkClient = new

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
soarez commented on code in PR #15584: URL: https://github.com/apache/kafka/pull/15584#discussion_r1537526255 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -324,6 +325,68 @@ class KRaftClusterTest { } } + def setConsumerByteRate( +