Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-08-02 Thread via GitHub
cmccabe commented on PR #16325: URL: https://github.com/apache/kafka/pull/16325#issuecomment-2266231744 We ended up doing this in: #16669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-08-02 Thread via GitHub
muralibasani commented on PR #16325: URL: https://github.com/apache/kafka/pull/16325#issuecomment-2265007883 Closing this, as the StorageTool class will be refactored in a different PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-08-02 Thread via GitHub
muralibasani closed pull request #16325: KAFKA-16518; Adding standalone argument for storage URL: https://github.com/apache/kafka/pull/16325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-10 Thread via GitHub
muralibasani commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1672845320 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -698,6 +663,42 @@ object StorageTool extends Logging { voterSet } + def createStandaloneVote

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-10 Thread via GitHub
muralibasani commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1672833818 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -112,20 +112,21 @@ object StorageTool extends Logging { setNodeId(config.nodeId). build()

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-08 Thread via GitHub
jsancio commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1668893365 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -300,19 +301,19 @@ object StorageTool extends Logging { } private def getUserScramCredentialRecord(

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-04 Thread via GitHub
muralibasani commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1665647113 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -503,24 +537,29 @@ object StorageTool extends Logging { } def formatCommand( -stream: Print

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-04 Thread via GitHub
muralibasani commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1665644755 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -102,6 +111,23 @@ object StorageTool extends Logging { setClusterId(clusterId). setNodeId

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-02 Thread via GitHub
muralibasani commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1661035915 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -285,6 +362,49 @@ Found problem: "Expected the default metadata.version to be 3.3-IV2")

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-07-02 Thread via GitHub
muralibasani commented on PR #16325: URL: https://github.com/apache/kafka/pull/16325#issuecomment-2200108407 @jsancio , updated with controller option ``` ./bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties -q 1@localhost:9093 metaPropertiesEnsem

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1651072253 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -102,6 +109,11 @@ object StorageTool extends Logging { setClusterId(clusterId). setNodeId(conf

Re: [PR] KAFKA-16518 : Adding standalone argument for storage [kafka]

2024-06-17 Thread via GitHub
jsancio commented on PR #16325: URL: https://github.com/apache/kafka/pull/16325#issuecomment-2173806713 > cat /tmp/kraft-combined-logs/__cluster_metadata-0/-00.checkpoint @muralibasani You can use `bin/kafka-dump-log --cluster-metadata-decoder --files /tm

Re: [PR] KAFKA-16518 : Adding standalone argument for storage [kafka]

2024-06-17 Thread via GitHub
jsancio commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1642996134 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -46,6 +51,8 @@ import scala.collection.mutable.ArrayBuffer object StorageTool extends Logging { + val

Re: [PR] KAFKA-16518 : Adding standalone argument for storage [kafka]

2024-06-15 Thread via GitHub
muralibasani commented on PR #16325: URL: https://github.com/apache/kafka/pull/16325#issuecomment-2170896788 @jsancio Output looks like below. ./bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties -s metaPropertiesEnsemble=MetaPropertiesEnsemble(metad

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-06-13 Thread via GitHub
muralibasani closed pull request #16094: KAFKA-16518; Adding standalone argument for storage URL: https://github.com/apache/kafka/pull/16094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-30 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619077543 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-30 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619077543 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-29 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619109614 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-29 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619109614 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-29 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619109614 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-29 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619077543 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori