Re: [PR] Log slow controller events [kafka]

2024-03-28 Thread via GitHub
soarez commented on PR #15622: URL: https://github.com/apache/kafka/pull/15622#issuecomment-2026356492 > events have relatively unique names (we include offset in some) so the cardinality is quite high I see. What I meant would result in too many more metrics. Makes sense then. --

Re: [PR] Log slow controller events [kafka]

2024-03-28 Thread via GitHub
mumrah commented on code in PR #15622: URL: https://github.com/apache/kafka/pull/15622#discussion_r1543844228 ## metadata/src/main/java/org/apache/kafka/controller/metrics/SlowEventsLogger.java: ## @@ -0,0 +1,58 @@ +package org.apache.kafka.controller.metrics; + +import

Re: [PR] Log slow controller events [kafka]

2024-03-28 Thread via GitHub
mumrah commented on PR #15622: URL: https://github.com/apache/kafka/pull/15622#issuecomment-2026321417 @soarez wdym by tagging here? Note that the events have relatively unique names (we include offset in some) so the cardinality is quite high. -- This is an automated message

Re: [PR] Log slow controller events [kafka]

2024-03-28 Thread via GitHub
soarez commented on code in PR #15622: URL: https://github.com/apache/kafka/pull/15622#discussion_r1543829135 ## metadata/src/main/java/org/apache/kafka/controller/metrics/SlowEventsLogger.java: ## @@ -0,0 +1,58 @@ +package org.apache.kafka.controller.metrics; + +import