chia7712 merged PR #15917:
URL: https://github.com/apache/kafka/pull/15917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15917:
URL: https://github.com/apache/kafka/pull/15917#issuecomment-2114202923
I will merge #15962 first and then rebase this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #15917:
URL: https://github.com/apache/kafka/pull/15917#issuecomment-2111631318
@showuon Please take a look if you have free time. I'd like to migrate all
tests of storage to new test infra after this PR gets merged.
--
This is an automated message from the
chia7712 commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1598369476
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java:
##
@@ -76,10 +77,17 @@ public Builder
showuon commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1598332128
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java:
##
@@ -76,10 +77,17 @@ public Builder
chia7712 commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1598307218
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -160,4 +167,34 @@ default Set supportedGroupProtocols() {
return
chia7712 commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1598293550
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
showuon commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1597526821
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##
@@ -171,111 +146,121 @@ private void
chia7712 commented on PR #15917:
URL: https://github.com/apache/kafka/pull/15917#issuecomment-2105525456
@kamalcph thanks for all your reviews. I have addressed them in
https://github.com/apache/kafka/pull/15917/commits/ff2c163633b341a6db9b1d9d838cec350a41ac15
--
This is an automated
kamalcph commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1597048065
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
chia7712 commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1596894830
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
kamalcph commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1596873472
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
12 matches
Mail list logo
