lianetm commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072864210
@chia7712 's comment makes sense to me, and heads-up, similar classes are
already defined in
[ConsumerGroupCommandTest](https://github.com/apache/kafka/blob/1b301b30207ed8fca9f0aea5cf940b
frankvicky commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072873129
> @frankvicky @m1a2st It seems your PR (#15766 and #15779) need a consumer
running in background. Hence, we can consider moving
`AbstractConsumerGroupExecutor`/`ConsumerGroupExecutor`
José Armando García Sancio created KAFKA-16607:
--
Summary: Update the KIP and metrics implementation to include the
new state
Key: KAFKA-16607
URL: https://issues.apache.org/jira/browse/KAFKA-16607
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-16604:
-
Assignee: Sagar Rao
> Deprecate ConfigDef.ConfigKey constructor from public APIs
>
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840163#comment-17840163
]
Sagar Rao commented on KAFKA-16604:
---
[~chia7712] , ok i have assigned it to myself.
>
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576631689
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -59,87 +63,66 @@ public Builder setCombined(boolean combined) {
}
public Builder setNu
[
https://issues.apache.org/jira/browse/KAFKA-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-16464.
---
Resolution: Duplicate
> New consumer fails with timeout in replication_replica_failure_test.py syste
[
https://issues.apache.org/jira/browse/KAFKA-16461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16461:
--
Description:
The {{security_test.py}} system test fails with the following error:
{quote}
* Consumer
[
https://issues.apache.org/jira/browse/KAFKA-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-16462.
---
Resolution: Duplicate
> New consumer fails with timeout in security_test.py system test
> --
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840191#comment-17840191
]
Kirk True commented on KAFKA-16217:
---
[~calvinliu]—I noticed the PR request 15541 is me
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576735920
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576738178
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576751637
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2073234352
re-trigger QA since some builds get terminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
riedelmax commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1576821065
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Andrew Schofield created KAFKA-16608:
Summary: AsyncKafkaConsumer doesn't honour interrupted thread
status on KafkaConsumer.poll(Duration)
Key: KAFKA-16608
URL: https://issues.apache.org/jira/browse/KAFKA-1660
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576836597
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -198,7 +177,7 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
}
[
https://issues.apache.org/jira/browse/KAFKA-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16608:
--
Component/s: consumer
> AsyncKafkaConsumer doesn't honour interrupted thread status on
> KafkaConsume
[
https://issues.apache.org/jira/browse/KAFKA-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-16608:
Assignee: Andrew Schofield
> AsyncKafkaConsumer doesn't honour interrupted thread
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16584:
Labels: needs-kip newbie (was: )
> Make log processing summary configurable or debug
> --
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840232#comment-17840232
]
Matthias J. Sax commented on KAFKA-16584:
-
I would prefer to make if configurabl
CalvinConfluent commented on PR #15759:
URL: https://github.com/apache/kafka/pull/15759#issuecomment-2073486845
@mumrah @artemlivshits Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
CalvinConfluent opened a new pull request, #15791:
URL: https://github.com/apache/kafka/pull/15791
This is a mitigation fix for the
https://issues.apache.org/jira/browse/KAFKA-16217. Exceptions should not block
closing the producers. This PR reverts a part of the change #13591
Re
CalvinConfluent opened a new pull request, #15792:
URL: https://github.com/apache/kafka/pull/15792
This is a mitigation fix for the
https://issues.apache.org/jira/browse/KAFKA-16217. Exceptions should not block
closing the producers. This PR reverts a part of the change #13591
Review
kirktrue commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2073652156
@appchemist—thanks for the PR, and sorry for the delay in response!
I've taken a first pass but am still working through the unit test changes.
--
This is an automated message fr
Kirk True created KAFKA-16609:
-
Summary: Update parse_describe_topic to support new topic describe
output
Key: KAFKA-16609
URL: https://issues.apache.org/jira/browse/KAFKA-16609
Project: Kafka
I
showuon commented on PR #13953:
URL: https://github.com/apache/kafka/pull/13953#issuecomment-2073673074
@Kiriakos1998 , could you rebase with the latest trunk branch, and resolve
the conflicts? I'd like to see if it still passes.
--
This is an automated message from the Apache Git Service
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2073680590
@lianetm @chia7712 Thanks for your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2073683927
@kirktrue Thanks for the heads-up!
If you have a moment, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16608:
--
Summary: AsyncKafkaConsumer doesn't honor interrupted thread status on
KafkaConsumer.poll(Duration) (
vamossagar12 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2073698582
The build got aborted again 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kirktrue commented on PR #15784:
URL: https://github.com/apache/kafka/pull/15784#issuecomment-2073707108
@lucasbru/@cadonna —please review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1577056133
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,109 +58,141 @@
import static org.ju
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1577073007
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -198,7 +177,7 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
}
showuon commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577162256
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+ * T
showuon commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577162256
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+ * T
showuon commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2073911312
Retriggering CI build :
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15616/11/
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
showuon commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2073928078
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #15748:
URL: https://github.com/apache/kafka/pull/15748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15787:
URL: https://github.com/apache/kafka/pull/15787#issuecomment-2073928975
Re-triggering CI build:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15787/3/
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
FrankYang0529 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577187165
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+
github-actions[bot] commented on PR #15258:
URL: https://github.com/apache/kafka/pull/15258#issuecomment-2073953728
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073966870
> I think deletionTask must be executed. From LogManager#startup to
LogManager#startupWithConfigOverrides is not asynchronous code, so deletionTask
must be put into scheduler queue. Durin
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971106
>
If we want to use taskRunning to check whether deletionTask is executed,
we may need a new value in LogManager class to keep scheduler future object.
WDYT?
> I think
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971783
Re-trigger CI build:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15773/5/
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577219150
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmentFail
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577220797
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java:
##
@@ -267,6 +267,18 @@ public String memberId() {
return
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073981282
@showuon thanks for the review and clarify scheduler behavior. Learn a lot 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577223693
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmen
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577225484
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmen
chia7712 merged PR #15714:
URL: https://github.com/apache/kafka/pull/15714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15774:
URL: https://github.com/apache/kafka/pull/15774#issuecomment-2074035809
```
./gradlew cleanTest :streams:test --tests
EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore
:tools:test --tests
MetadataQuorumCommandTest.testDescr
chia7712 merged PR #15774:
URL: https://github.com/apache/kafka/pull/15774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2074037067
@TaiJuWu Could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kamalcph commented on PR #15787:
URL: https://github.com/apache/kafka/pull/15787#issuecomment-2074099558
Opened #15793 to port it to v3.7 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kamalcph opened a new pull request, #15793:
URL: https://github.com/apache/kafka/pull/15793
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577316104
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmentFail
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2074186450
Thanks for the patch @jeqo!
I was able to reproduce the exception mentioned in the ticket by calling
close in-middle of collecting the aborted transactions. The fix doesn't resolv
showuon commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1577340553
##
core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala:
##
@@ -194,6 +199,8 @@ class AdminZkClientTest extends QuorumTestHarness with
Logging with RackAwareTes
101 - 159 of 159 matches
Mail list logo
