cvs commit: jakarta-jmeter/src/jorphan/org/apache/jorphan/io TextFile.java

2004-02-20 Thread sebb
sebb2004/02/20 16:46:20 Modified:src/jorphan/org/apache/jorphan/io TextFile.java Log: Try to close even on Exceptions Revision ChangesPath 1.8 +11 -4 jakarta-jmeter/src/jorphan/org/apache/jorphan/io/TextFile.java Index: TextFile.java =

cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/resources messages.metaprops

2004-02-20 Thread sebb
sebb2004/02/20 15:48:10 Modified:src/core/org/apache/jmeter/resources messages.metaprops Log: Make ascii Revision ChangesPath 1.2 +0 -0 jakarta-jmeter/src/core/org/apache/jmeter/resources/messages.metaprops Index: messages.metaprops

DO NOT REPLY [Bug 26605] - Java Config elements override samplers

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27114] - JAVA Sampler and JAVA Request Defaults

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: [HEADS UP] Possible problems with equals() and hashCode()

2004-02-20 Thread BAZLEY, Sebastian
Just tried a brief test without equals - Jmeter seems to run a simple test OK, but the clone tests complain, and Jmeter says the test plan has not been saved even though it has only just started empty! The latter might be hard to fix, and I need to do a more thorough test than just downloading a s

DO NOT REPLY [Bug 27112] - User Parameters should use scrollbars

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27114] New: - JAVA Sampler and JAVA Request Defaults

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27112] New: - User Parameters should use scrollbars

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: [HEADS UP] Possible problems with equals() and hashCode()

2004-02-20 Thread BAZLEY, Sebastian
Yes, I think I did, but that was before I found the symmetry bug in HashTree. I'll try again - but I'm sure some clone tests will fail as they check for cloned items being equal. I suppose if equality testing was required for purposes other than Collections we could implement a sameAs() or simila

RE: Possible Thread enhancements

2004-02-20 Thread BAZLEY, Sebastian
>-Original Message- >From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED] >Sent: 20 February 2004 14:26 >To: JMeter Developers List >Subject: Re: Possible Thread enhancements > > >If this how it's working? Well, I think so - I was thinking of having a debug flag which caused the get/set

Re: [HEADS UP] Possible problems with equals() and hashCode()

2004-02-20 Thread Jordi Salvat i Alabart
Yes, let's clean up! Have you tried removing those equals() methods? BAZLEY, Sebastian wrote: I've been looking at equals/hashcode following some warnings from FindBugs, but not resolved the problems fully. Thought it would be useful to summarise what I've found so far: If a class over-rides equal

Re: Possible Thread enhancements

2004-02-20 Thread Jordi Salvat i Alabart
If this how it's working? Yes, it would make sense to keep the context somewhere that can be accessed easily. The solution you propose sounds good. Maybe we should make that part of the TestElement interface (and of course implement it in the AbstractTestElement). BTW, what's the mechanism use

DO NOT REPLY [Bug 27034] - OutOfMemoryError occures while running Tests with Ant

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27034] - OutOfMemoryError occures while running Tests with Ant

2004-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

[HEADS UP] Possible problems with equals() and hashCode()

2004-02-20 Thread BAZLEY, Sebastian
I've been looking at equals/hashcode following some warnings from FindBugs, but not resolved the problems fully. Thought it would be useful to summarise what I've found so far: If a class over-rides equals(), it should also override hashCode(), otherwise it cannot be used reliably in Collections w

Possible Thread enhancements

2004-02-20 Thread BAZLEY, Sebastian
All the Samplers (and indeed most/all other test elements) have individual instances for each test thread (plus one or two others). At the moment, they the JMeter context service to access properties specific to the thread, but this requires obtaining the thread name and looking up the appropriate

RE: Unit test failures

2004-02-20 Thread BAZLEY, Sebastian
StopThread was a bit of a hack I put into StringFromFile to allow it to stop the thread - by throwing an exception. The code currently does: if (values.length >= PARAM_END){// Are we processing a file sequence? log.info("Detected end of sequence.");