StopThread was a bit of a hack I put into StringFromFile to allow it to stop
the thread - by throwing an exception.

The code currently does:

if (values.length >= PARAM_END){// Are we processing a file sequence?
                        log.info("Detected end of sequence.");
                        throw new RuntimeException("Stop Thread");//TODO
there has to be a better way...

Now that there are thread and test stop methods, it (sh|c)ould probably use
one of those instead.

You should find that there is also a message in the log file.

I suspect what has happened in this case is that SFF cannot find the test
file(s), perhaps because it was not started in bin, or perhaps they are not
there ...

Which reminds me, I think we could simplify thread communication, but I'll
send a separate e-mail about it...

S.

>-----Original Message-----
>From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED]
>Sent: 20 February 2004 00:55
>To: JMeter Developers List
>Subject: Unit test failures
>
>
>Is it just me?
>
>Salut,
>
>Jordi.
>
>         [java] There was 1 error:
>         [java] 1) 
>SFFTest1(org.apache.jmeter.functions.PackageTest)java.lang.Runt
>imeException: 
>Stop Thread
>         [java]        at 
>org.apache.jmeter.functions.StringFromFile.execute(StringFromFi
>le.java:242)
>         [java]        at 
>org.apache.jmeter.functions.AbstractFunction.execute(AbstractFu
>nction.java:54)
>         [java]        at 
>org.apache.jmeter.functions.PackageTest.SFFTest1(PackageTest.java:113)
>         [java]        at 
>sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
>Method)
>         [java]        at 
>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccesso
>rImpl.java:39)
>         [java]        at 
>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMetho
>dAccessorImpl.java:25)
>         [java]        at 
>org.apache.jorphan.test.AllTests.main(AllTests.java:195)
>         [java] There were 2 failures:
>         [java] 1) 
>checkGuiSet(org.apache.jmeter.junit.JMeterTest)junit.framework.
>AssertionFailedError: 
>Should not have any names left over expected:<0> but was:<5>
>         [java]        at 
>org.apache.jmeter.junit.JMeterTest.checkGuiSet(JMeterTest.java:233)
>         [java]        at 
>sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
>Method)
>         [java]        at 
>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccesso
>rImpl.java:39)
>         [java]        at 
>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMetho
>dAccessorImpl.java:25)
>         [java]        at 
>org.apache.jorphan.test.AllTests.main(AllTests.java:195)
>         [java] 2) 
>testLoadAndSave(org.apache.jmeter.save.SaveService$Test)junit.f
>ramework.AssertionFailedError: 
>One or more failures detected
>         [java]        at 
>org.apache.jmeter.save.SaveService$Test.testLoadAndSave(SaveSer
>vice.java:1238)
>         [java]        at 
>sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
>Method)
>         [java]        at 
>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccesso
>rImpl.java:39)
>         [java]        at 
>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMetho
>dAccessorImpl.java:25)
>         [java]        at 
>org.apache.jorphan.test.AllTests.main(AllTests.java:195)
>         [java]
>         [java] FAILURES!!!
>         [java] Tests run: 705,  Failures: 2,  Errors: 1
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>


___________________________________________________________________________

This e-mail and the documents attached are confidential and intended solely
for the addressee; it may also be privileged. If you receive this e-mail in
error, please notify the sender immediately and destroy it. As its integrity
cannot be secured on the Internet, the Atos Origin group liability cannot be
triggered for the message content. Although the sender endeavours to maintain
a computer virus-free network, the sender does not warrant that this
transmission is virus-free and will not be liable for any damages resulting
from any virus transmitted. 
___________________________________________________________________________


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to