Author: sebb Date: Fri Sep 19 17:38:20 2008 New Revision: 697305 URL: http://svn.apache.org/viewvc?rev=697305&view=rev Log: Counter is a Config item, not PreProcessor Summariser is a Listener, not a PostProcessor
Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/CounterConfigGui.java jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/SummariserGui.java jakarta/jmeter/trunk/xdocs/changes.xml Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/CounterConfigGui.java URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/CounterConfigGui.java?rev=697305&r1=697304&r2=697305&view=diff ============================================================================== --- jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/CounterConfigGui.java (original) +++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/CounterConfigGui.java Fri Sep 19 17:38:20 2008 @@ -20,14 +20,14 @@ import javax.swing.JCheckBox; +import org.apache.jmeter.config.gui.AbstractConfigGui; import org.apache.jmeter.modifiers.CounterConfig; -import org.apache.jmeter.processor.gui.AbstractPreProcessorGui; import org.apache.jmeter.testelement.TestElement; import org.apache.jmeter.util.JMeterUtils; import org.apache.jorphan.gui.JLabeledTextField; import org.apache.jorphan.gui.layout.VerticalLayout; -public class CounterConfigGui extends AbstractPreProcessorGui { +public class CounterConfigGui extends AbstractConfigGui { private JLabeledTextField startField, incrField, endField, varNameField, formatField; private JCheckBox perUserField; Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/SummariserGui.java URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/SummariserGui.java?rev=697305&r1=697304&r2=697305&view=diff ============================================================================== --- jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/SummariserGui.java (original) +++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/SummariserGui.java Fri Sep 19 17:38:20 2008 @@ -21,17 +21,14 @@ import java.awt.BorderLayout; import org.apache.jmeter.reporters.Summariser; -import org.apache.jmeter.processor.gui.AbstractPostProcessorGui; import org.apache.jmeter.testelement.TestElement; +import org.apache.jmeter.visualizers.gui.AbstractListenerGui; /** - * Create a summariser test element. - * - * Note: This is not really a PostProcessor, but that seems to be the closest of - * the existing types. + * Create a summariser test element GUI. * */ -public class SummariserGui extends AbstractPostProcessorGui { +public class SummariserGui extends AbstractListenerGui { public SummariserGui() { super(); Modified: jakarta/jmeter/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=697305&r1=697304&r2=697305&view=diff ============================================================================== --- jakarta/jmeter/trunk/xdocs/changes.xml (original) +++ jakarta/jmeter/trunk/xdocs/changes.xml Fri Sep 19 17:38:20 2008 @@ -68,12 +68,17 @@ <h3>Incompatible changes</h3> <p> -The test element "Save Results to a file" is now shown as a Listener. -It was previously shown as a Post-Processor, even though it was in fact a Listener. -This change only affects the icon that is displayed and the location in the Gui pop-up menus. -It does not affect test plans or test behaviour. +The test elements "Save Results to a file" and "" are now shown as Listeners. +They were previously shown as Post-Processors, even though they are implemented as Listeners. +</p> +<p> +The Counter element is now shown as a Configuration element. +It was previously shown as a Pre-Processor, even though it is implemented as a Config item. +</p> +<p> +The above changes only affect the icons that are displayed and the locations in the GUI pop-up menus. +They do not affect test plans or test behaviour. </p> - <p> Moved the Scoping Rules sub-section from Section 3. "Building a Test Plan" to Section 4. "Elements of a test plan" </p> @@ -114,6 +119,7 @@ <ul> <li>Introduce AbstractListenerGui class to make it easier to create Listeners with no visual output</li> <li>Assertions run after PostProcessors; change order of pop-up menus accordingly</li> +<li>Remove unnecessary clone() methods from function classes</li> </ul> </section> </body> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]