Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Robert Hanson
Well, we aren't exporting SD files, just MOL files. Let's just implement an SDF file writer and do that right rather than faking it. 2010/12/16 Angel Herráez > I have found out that MOL files exported by Jmol, using the "write" > command, fail to be > opened in PowerMV, a free SDF viewer. > So I

Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Angel Herráez
> Well, we aren't exporting SD files, just MOL files. Let's just > implement an SDF file writer and do that right rather than faking it. Bob, you're right, but that's not exactly the situation. I didn't make myself clear enough. MOL and SD formats are exactly the same except for the line

[Jmol-developers] scripting doc for WRITE COORDS SPT

2010-12-17 Thread Angel Herráez
Bob, the doc http://chemapps.stolaf.edu/jmol/docs/#writemodel says "In the case of SPT, a script file containing the coordinates of the model." How is that? Only the state script is saved (I always thought that was it).

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Angel Herráez
Hi Nico I have got your changes but now I cannot build Jmol locally; I get these messages: Do you have any tips? My local building using Eclipse is not something I trust much, but it was working yesterday [javac] F:\webs\eclipse\Jmol-trunk\Jmol\src\jmol\i18n\GT.java:123: warning: unmappable

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Angel Herráez
Nico, that looks good (I still have trouble building so don't see it well) but we should revise the order of languages in the popup menu. It seems to be alphabetic in the English names, but these are not displayed when you are on another language. So I'd vote for putting the 2-letter (4-letter)

Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Angel Herráez
Hi Bob, I've looked at your commit to SVN. Is there a reason why you want to keep the headers for the MOL export as they were? I think we should conform to MDL-Symyx for both SDF and MOL The only thing different for SDF would be the line Regards

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Nicolas Vervelle
Hi Angel, Building works fine on my computer. The problems seems to come from the encoding used by Java when you compile (I had to change GT.java encoding to UTF8). I've just committed a modification to force using UTF8 when building. Tell me if it works better. Nico 2010/12/17 Angel Herráez >

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Nicolas Vervelle
2010/12/17 Angel Herráez > Nico, that looks good (I still have trouble building so don't see it well) > but we should revise the order of languages in the popup menu. > It seems to be alphabetic in the English names, but these are not displayed > when you are on > another language. > > So I'd vot

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Angel Herráez
Works great, Nico! No complains building now. All languages display well in the menu (I see blocks for those whose fonts I don't have, but I guess that's fine) The addition of language per demand is wonderful addition I have commited a small fix - English was being displayed only in Spanish. No

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Nicolas Vervelle
Angel, The menu is broken on my computer with the last fix. It only shows 4 lines : "null - Català", ..., "null - Deutsch". Nico 2010/12/17 Angel Herráez > Works great, Nico! > > No complains building now. > All languages display well in the menu (I see blocks for those whose fonts > I don't h

Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Robert Hanson
Ah, you are too quick for me! I wasn't done. See latest installment. -- read/write SDF files (SDF) -- read/write V2000 files (MOL or V2000) -- read/write V3000 files (V3000 or atomno > 999 or bondno > 999) Check it out. Bob 2010/12/17 Angel Herráez > Hi Bob, > > I've looked at your commit t

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Robert Hanson
Nico, those need to be entered in Unicode format, not like that, I think. Bob 2010/12/17 Angel Herráez > Hi Nico > > I have got your changes but now I cannot build Jmol locally; I get these > messages: > > Do you have any tips? My local building using Eclipse is not something I > trust much

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Robert Hanson
I see -- Angel, update the full Jmol, not just the src. You need a new project settings file. On Fri, Dec 17, 2010 at 4:36 PM, Robert Hanson wrote: > Nico, those need to be entered in Unicode format, not like that, I think. > > Bob > > 2010/12/17 Angel Herráez > >> Hi Nico >> >> I have got yo

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Nicolas Vervelle
Bob, It's fixed, the problem was only that there was no encoding specified for the build, so the encoding used was depending on the computer used to build. I changed the build to force UTF8 encoding. Nico On Fri, Dec 17, 2010 at 11:44 PM, Robert Hanson wrote: > I see -- Angel, update the full

[Jmol-developers] Errors in unit tests

2010-12-17 Thread Nicolas Vervelle
Hi Bob, Several errors in unit tests. ** junit.framework.AssertionFailedError: Error returned for ..\Jmol-datafiles\mol\f_socl2b.mol: Error reading file at line 9: 1 2 1 null for file f_socl2b.mol type Mol ** junit.framework.AssertionFailedError: Error returned for ..\Jmol-datafiles\

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Robert Hanson
great, and I just built it without a problem as well. On Fri, Dec 17, 2010 at 4:46 PM, Nicolas Vervelle wrote: > Bob, > > It's fixed, the problem was only that there was no encoding specified for > the build, so the encoding used was depending on the computer used to build. > I changed the build

Re: [Jmol-developers] Errors in unit tests

2010-12-17 Thread Robert Hanson
got it -- and notice that now Jmol automatically converts 2D V3000 files into 3D. See Jmol-dataFiles/mol/alanine.2D.v3000 On Fri, Dec 17, 2010 at 4:49 PM, Nicolas Vervelle wrote: > Hi Bob, > > Several errors in unit tests. > > ** > junit.framework.AssertionFailedError: Error returned for > ..

Re: [Jmol-developers] scripting doc for WRITE COORDS SPT

2010-12-17 Thread Robert Hanson
If you look in that SPT file, you will see a DATA "coord set" block. 2010/12/17 Angel Herráez > Bob, the doc > http://chemapps.stolaf.edu/jmol/docs/#writemodel > says > "In the case of SPT, a script file containing the coordinates of the > model." > > How is that? Only the state script is

Re: [Jmol-developers] Errors in unit tests

2010-12-17 Thread Nicolas Vervelle
There's just one error left (repeated over and over) Error: [..\Jmol-datafiles\tests\scripts\run\monster_script.spt] Could not instantiate shape:org.jmol.shape.Labels - java.lang.NullPointerException org.jmol.shape.Labels - 75 - initShape org.jmol.shape.Shape - 114 - initializeShape org.jmol.viewe

Re: [Jmol-developers] localizations available from popup

2010-12-17 Thread Angel Herráez
Bob, the month is wrong (zero-based) __Jmol-12_11181000533D 1 1.0 0.0 0 should be __Jmol-12_12181000533D 1 1.0 0.0 0 That's why I added one 1+ c.get(Calendar.MONTH) -- Lotusphere 20

Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Angel Herráez
(Sorry I sent this to the wrong thread: localizations) Bob, the month is wrong (zero-based) __Jmol-12_11181000533D 1 1.0 0.0 0 should be __Jmol-12_12181000533D 1 1.0 0.0 0 That's why I added one 1+ c.get(Calendar.MONTH) Also, I think the position of the decim

Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Robert Hanson
Ah, sure. I missed that. This means you are up late on a Friday night. Hmm 2010/12/17 Angel Herráez > (Sorry I sent this to the wrong thread: localizations) > > Bob, the month is wrong (zero-based) > __Jmol-12_11181000533D 1 1.0 0.0 0 > should be > __Jmol-12_12181000533D

Re: [Jmol-developers] MOLfile exported

2010-12-17 Thread Robert Hanson
A satisfying day! After my development laptop died yesterday, that is especially good new. Take a look at this: version=12.1.26_dev # new feature: write MOL creates V2000 file # new feature: write SDF creates multi-model SDfile based on models of selected atoms # new feature: over-run of SDF, MOL

Re: [Jmol-developers] Errors in unit tests

2010-12-17 Thread Robert Hanson
Interesting. Fixed. On Fri, Dec 17, 2010 at 5:38 PM, Nicolas Vervelle wrote: > There's just one error left (repeated over and over) > > Error: [..\Jmol-datafiles\tests\scripts\run\monster_script.spt] Could not > instantiate shape:org.jmol.shape.Labels - java.lang.NullPointerException > org.jmol.s