Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-29 Thread Fabian Dortu
On Thu, 2002-11-28 at 18:59, Egon Willighagen wrote: > On Thursday 28 November 2002 10:00, Fabian Dortu wrote: > > On Wed, 2002-11-27 at 18:50, Miguel Howard wrote: > > > I think that some of the code that is in the old Atom.java should be > > > moved out of there. > > > For example, all the refere

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-28 Thread mth
> On Thursday 28 November 2002 10:33, E.L. Willighagen wrote: >> > I think that some of the code that is in the old Atom.java should be >> moved out of there. >> > For example, all the references to transform and screenPosition (and >> screenX/Y/Z/Diameter) should be part of AtomShape, not part of

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-28 Thread Egon Willighagen
On Thursday 28 November 2002 10:33, E.L. Willighagen wrote: > > I think that some of the code that is in the old Atom.java should be > > moved out of there. > > For example, all the references to transform and screenPosition (and > > screenX/Y/Z/Diameter) should be part of AtomShape, not part of th

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-28 Thread Egon Willighagen
On Thursday 28 November 2002 10:00, Fabian Dortu wrote: > On Wed, 2002-11-27 at 18:50, Miguel Howard wrote: > > I think that some of the code that is in the old Atom.java should be > > moved out of there. > > For example, all the references to transform and screenPosition (and > > screenX/Y/Z/Diame

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-28 Thread E.L. Willighagen
On Wednesday 27 November 2002 18:50, Miguel Howard wrote: > My thoughts ... More than welcome... I appreciate any input much. > I think that some of the code that is in the old Atom.java should be moved > out of there. > For example, all the references to transform and screenPosition (and > scree

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-28 Thread Fabian Dortu
On Wed, 2002-11-27 at 18:50, Miguel Howard wrote: > Egon, > > My thoughts ... > > I think that some of the code that is in the old Atom.java should be moved > out of there. > For example, all the references to transform and screenPosition (and > screenX/Y/Z/Diameter) should be part of AtomShape,

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-27 Thread mth
> Ok, had not really planned it this soon, but ok... if you're waiting for > me to make the move... ;) I didn't mean to be rushing you along. I have plenty to do with scripting. So work at whatever pace you want. Miguel --- This SF.net em

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-27 Thread Miguel Howard
Egon, My thoughts ... I think that some of the code that is in the old Atom.java should be moved out of there. For example, all the references to transform and screenPosition (and screenX/Y/Z/Diameter) should be part of AtomShape, not part of the basic Atom representation. You may want to keep t

Re: Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-27 Thread E.L. Willighagen
On Wednesday 27 November 2002 16:55, E.L. Willighagen wrote: > Like Miguel, I will check in the changes gradually, and hope that things > don't break. Miguel, please continue the work you are doing now... My goal > is to keep the 'old' Jmol methods in as long a I can, possibly making the > old meth

Move to CDK (was: [Jmol-developers] fine rotation)

2002-11-27 Thread E.L. Willighagen
On Wednesday 27 November 2002 16:02, mth wrote: > >> Yes, I think it's usefull and quite easy to do. I will do it. > >> z-ordering is probably impossible to handle correclty with our pseudo > >> 3D. > > > > I am trying to learn more about 'real 3D' to improve our pseudo-3D. > > > > The main reason

Re: [Jmol-developers] fine rotation

2002-11-27 Thread mth
>> Yes, I think it's usefull and quite easy to do. I will do it. >> z-ordering is probably impossible to handle correclty with our pseudo >> 3D. > I am trying to learn more about 'real 3D' to improve our pseudo-3D. > > The main reason I went in to work on this section of the code was to fix > a bug

Re: [Jmol-developers] fine rotation

2002-11-24 Thread mth
> But a new button to recenter the molecule would be nice. That button would be easy to add. > Actually there is now an easy way to do it: > > void rotate(Point3f center, AxisAngle4f axisAngle) { > > oldcenter = center; > setCenter(center); > rotate(axisAngle); > repaint(); > setCenter(o

Re: [Jmol-developers] fine rotation

2002-11-24 Thread Fabian Dortu
> > Below are some thoughts and observations: > > Fundamentally, I think your code is correct. > > I am still struggling to understand some of the matrix transformation > processes. The code in getViewTransformMatrix() is essentially the same > code that was there before. As I was trying to fig

Re: [Jmol-developers] fine rotation

2002-11-22 Thread mth
> Miguel, > > I try to implement the rotational stuff we discussed previously but I > get some problems. > The purpose is to rotate around an axis defined by "axisAngle" and > passing through the point "point" (see code below). The rotation angle > is included in "axisAngle". The basic idea in the

[Jmol-developers] fine rotation

2002-11-22 Thread Fabian Dortu
Miguel, I try to implement the rotational stuff we discussed previously but I get some problems. The purpose is to rotate around an axis defined by "axisAngle" and passing through the point "point" (see code below). The rotation angle is included in "axisAngle". The basic idea in the code is to