On 10/16/2013 7:18 AM, Jaroslav Bachorik wrote:
Please, review this simple test change.
The test tries to get the number of times a certain thread was blocked
during the test run and intermittently fails with the difference of 1
- the expected number is 4 but the reported number is 3.
When u
Thanks Paul and Daniel for the review.
Shanliang
Daniel Fuchs wrote:
Hi Shanliang,
Looks good!
-- daniel
On 10/16/13 3:58 PM, shanliang wrote:
Hi,
Please review the following fix, main issue here is that we should clone
an internal variable before returning.
webrev:
http://cr.openjdk.jav
Looks good!
Nit: for(int i=0;i<100;i++) should have more spaces: for (int i = 0; i < 100;
i++)
Thanks,
/Staffan
On 16 okt 2013, at 16:18, Jaroslav Bachorik
wrote:
> Please, review this simple test change.
>
> The test tries to get the number of times a certain thread was blocked during
>
Looks good!
Thanks,
/Staffan
On 16 okt 2013, at 16:44, Jaroslav Bachorik
wrote:
> On 2.10.2013 12:55, Jaroslav Bachorik wrote:
>> On 20.9.2013 14:54, shanliang wrote:
>>> Jaroslav,
>>>
>>> It is a good idea to use the RMI Testlibrary.
>>>
>>> Better to call:
>>>agent.close();
>>>
>>
Looks good to me.
Thanks,
/Staffan
On 17 okt 2013, at 14:09, Jaroslav Bachorik
wrote:
> On 17.10.2013 13:07, David Holmes wrote:
>> On 17/10/2013 8:10 PM, Jaroslav Bachorik wrote:
>>> Hi David,
>>>
>>> On 17.10.2013 04:26, David Holmes wrote:
Hi Jaroslav,
Minor nit: os::elapse
