Re: jmx-dev RFR Doclint cleanup of javax.management

2013-11-12 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 12 Nov 2013, at 15:52, roger riggs wrote: > Hi Jaroslav, > > Thanks for the review and comments. > > I derived the changes from the warning messages from -Xdoclint. > > For both and the closing tag is optional in HTML 4.01 Transitional > generated by java

Re: jmx-dev RFR Doclint cleanup of javax.management

2013-11-12 Thread Jaroslav Bachorik
Hi Roger, On 12.11.2013 15:52, roger riggs wrote: Hi Jaroslav, Thanks for the review and comments. I derived the changes from the warning messages from -Xdoclint. For both and the closing tag is optional in HTML 4.01 Transitional generated by javadoc. The convention in the core libraries s

Re: jmx-dev RFR Doclint cleanup of javax.management

2013-11-12 Thread roger riggs
Hi Jaroslav, Thanks for the review and comments. I derived the changes from the warning messages from -Xdoclint. For both and the closing tag is optional in HTML 4.01 Transitional generated by javadoc. The convention in the core libraries seems to be to omit them, reducing the amount of [u

Re: jmx-dev RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-12 Thread Yekaterina Kantserova
Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary). The example how to use can be found in sun/management/jmxremote/bootstrap/LocalManagementTest.java.

jmx-dev RFR: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java,

2013-11-12 Thread Erik Gahlin
Could I please have a review, fix is to run test in separate vm. I also removed warnings and allowed the exception to propagate. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/6959636_1/ Bug: https://bugs.openjdk.java.net/browse/JDK-6959636

Re: jmx-dev RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-12 Thread Yekaterina Kantserova
Sorry, ProcessBuilder's createJavaProcessBuilder() of course, which in turn uses JDKToolLauncher. // Katja On 11/07/2013 03:24 PM, Yekaterina Kantserova wrote: Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixe

jmx-dev RFR Doclint cleanup of javax.management

2013-11-12 Thread roger riggs
This changeset addresses the warnings and errors of doclint and improves the quality of the generated html. No spec or implementation is changed by this changeset The changes address issues including html syntax, accessibility issues, and html tag improper use. Refer to the error log attached to

Re: jmx-dev RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-12 Thread Yekaterina Kantserova
On 11/07/2013 03:29 PM, Jaroslav Bachorik wrote: On 7.11.2013 15:24, Yekaterina Kantserova wrote: Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary). The

Re: jmx-dev RFR Doclint cleanup of javax.management

2013-11-12 Thread Jaroslav Bachorik
Hi Roger, The following comments are based on the presumption that the contained HTML should be well-formed. src/share/classes/javax/management/MBeanFeatureInfo.java L183, L231 - missing src/share/classes/javax/management/MBeanInfo.java L640, L686 - missing src/share/classes/javax/manageme