Re: jmx-dev RFR 7132590: javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java fails in JDK8-B22

2014-08-21 Thread shanliang
Jaroslav Bachorik wrote: On 08/21/2014 03:55 PM, shanliang wrote: Jaroslav, The fix should be good to fix the failure. It makes me think a special case, suppose that the test waits 2 notifications, but the test might receive one unexpected notification with some more waiting, for example, with

Re: jmx-dev RFR 7132590: javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java fails in JDK8-B22

2014-08-21 Thread Jaroslav Bachorik
On 08/21/2014 03:55 PM, shanliang wrote: Jaroslav, The fix should be good to fix the failure. It makes me think a special case, suppose that the test waits 2 notifications, but the test might receive one unexpected notification with some more waiting, for example, with the old version, 2 expect

Re: jmx-dev RFR 7132590: javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java fails in JDK8-B22

2014-08-21 Thread shanliang
Jaroslav, The fix should be good to fix the failure. It makes me think a special case, suppose that the test waits 2 notifications, but the test might receive one unexpected notification with some more waiting, for example, with the old version, 2 expected notifications arrive within the firs

Re: jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Jaroslav Bachorik
On 08/21/2014 02:52 PM, Staffan Larsen wrote: Looks good, except I don’t think you wanted to add the test/sources.list file? Fixed the webrev - http://cr.openjdk.java.net/~jbachorik/8040692/webrev.01 - not to include test/sources.list file. Thanks for the review. -JB- /Staffan On 21 au

jmx-dev RFR 7132590: javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java fails in JDK8-B22

2014-08-21 Thread Jaroslav Bachorik
Please, review the following test change. Issue : https://bugs.openjdk.java.net/browse/JDK-7132590 Webrev: http://cr.openjdk.java.net/~jbachorik/7132590/webrev.00 Currently, the test waits for an arbitrary time until it gives up on receiving the notifications. This leads to intermittent failure

Re: jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Jaroslav Bachorik
On 08/21/2014 02:52 PM, Staffan Larsen wrote: Looks good, except I don’t think you wanted to add the test/sources.list file? Nope. I've just realized that my review script includes all the applied MQ patches instead of only the last one. -JB- /Staffan On 21 aug 2014, at 14:44, Jaroslav B

Re: jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Staffan Larsen
Looks good, except I don’t think you wanted to add the test/sources.list file? /Staffan On 21 aug 2014, at 14:44, Jaroslav Bachorik wrote: > Please, review this simple fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8040692 > Webrev: http://cr.openjdk.java.net/~jbachorik/8040692/web

jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Jaroslav Bachorik
Please, review this simple fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8040692 Webrev: http://cr.openjdk.java.net/~jbachorik/8040692/webrev.00 On embedded platforms it is necessary to provide "-XX:+UsePerfData" flag in order to make the performance counters accessible. This fix does t