Hi Jaroslav,
619 final boolean[] retry = new boolean[]{false};
I wonder whether using an AtomicBoolean would be safer.
It is not immediately clear whether 'retry' might be modified
in a different thread - but using an AtomicBoolean would make it
immediately clear that it does
Looks good!
Thanks,
/Staffan
On 24 sep 2014, at 11:35, Jaroslav Bachorik
wrote:
> Thanks, Staffan
>
> On 09/23/2014 08:20 PM, Staffan Larsen wrote:
>> I think we should add some logging to say that we are retrying.
>>
>> nit: some weird indention on line 623.
>
> I added logging and improve
Thanks, Staffan
On 09/23/2014 08:20 PM, Staffan Larsen wrote:
I think we should add some logging to say that we are retrying.
nit: some weird indention on line 623.
I added logging and improved the retry detection logic a bit (in the
previous version the retry counter could have got decremen
