Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v22]

2023-05-18 Thread David Holmes
On Thu, 18 May 2023 13:55:59 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v19]

2023-05-18 Thread David Holmes
On Thu, 18 May 2023 13:56:06 GMT, Paul Hohensee wrote: >> Changed. Not sure atomic load is needed. > > Even though this version passed the pre-submit tests, which include the new > versions of ThreadAllocatedBytes.java, running it more often on a host with > many hardware threads resulted in fa

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v19]

2023-05-18 Thread Paul Hohensee
On Thu, 18 May 2023 12:41:49 GMT, Paul Hohensee wrote: >> src/hotspot/share/services/threadService.hpp line 113: >> >>> 111: // No need for atomicity, method is called under the Threads_lock >>> 112: _exited_allocated_bytes += size; >>> 113: } >> >> As there is a lock-free read howeve

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v22]

2023-05-18 Thread Paul Hohensee
> Please review this addition to com.sun.management.ThreadMXBean that returns > the total number of bytes allocated on the Java heap since JVM launch by both > terminated and live threads. > > Because this PR adds a new interface method, I've updated the JMM_VERSION to > 4, but would be happy t

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v19]

2023-05-18 Thread Paul Hohensee
On Tue, 16 May 2023 04:34:29 GMT, David Holmes wrote: >> Paul Hohensee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 26 additional >> commits