Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v26]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 16:50:55 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v26]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 16:50:55 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-25 Thread Mandy Chung
On Wed, 24 May 2023 16:50:59 GMT, Paul Hohensee wrote: >> test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java line 160: >> >>> 158: try { >>> 159: curThread.join(); >>> 160: } catch (InterruptedException e) { >> >> should it just let `InterruptedExcep

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v26]

2023-05-25 Thread Paul Hohensee
On Wed, 24 May 2023 16:50:55 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-25 Thread Kevin Walls
On Tue, 23 May 2023 02:29:19 GMT, David Holmes wrote: >> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8304074: atomic load needed in exited_allocated_bytes > > src/hotspot/share/services/management.cpp line 2104: > >> 2

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v24]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 16:36:05 GMT, Paul Hohensee wrote: >> Paul Hohensee has updated the pull request incrementally with 63 additional >> commits since the last revision: >> >> - 8304074: Change UnsupportedOperationException in javadoc comment to >> {@code UnsupportedOperationException} >> -