Re: jmx-dev RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

Re: jmx-dev RFR: 8311000: missing @since info in jdk.management

2023-06-30 Thread Kevin Walls
On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote: > Simple addition of a doc tag. > > src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java > is introduced in jdk7 by > 7036199: Adding a notification to the implementation of > GarbageCollectorMXBeans Thanks for the

jmx-dev Integrated: 8311000: missing @since info in jdk.management

2023-06-30 Thread Kevin Walls
On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote: > Simple addition of a doc tag. > > src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java > is introduced in jdk7 by > 7036199: Adding a notification to the implementation of > GarbageCollectorMXBeans This pull reque

Re: jmx-dev RFR: 8311000: missing @since info in jdk.management [v2]

2023-06-30 Thread Kevin Walls
> Simple addition of a doc tag. > > src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java > is introduced in jdk7 by > 7036199: Adding a notification to the implementation of > GarbageCollectorMXBeans Kevin Walls has updated the pull request incrementally with one additi

Re: jmx-dev RFR: 8310988: Missing @since tags in java.management.rmi

2023-06-30 Thread Kevin Walls
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote: > Simple doc tag addition. > > These are files which describe an interface that has been with us since 1.5. > The files themselves were previously generated at build time, but have been > in the repo since jdk15. But the API is since 1.5.

jmx-dev Integrated: 8310988: Missing @since tags in java.management.rmi

2023-06-30 Thread Kevin Walls
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote: > Simple doc tag addition. > > These are files which describe an interface that has been with us since 1.5. > The files themselves were previously generated at build time, but have been > in the repo since jdk15. But the API is since 1.5.

Re: jmx-dev RFR: 8310988: Missing @since tags in java.management.rmi [v2]

2023-06-30 Thread Kevin Walls
> Simple doc tag addition. > > These are files which describe an interface that has been with us since 1.5. > The files themselves were previously generated at build time, but have been > in the repo since jdk15. But the API is since 1.5. > > The other file mentioned in the bug is not a publi