Re: jmx-dev RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Valerie Peng
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: jmx-dev RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Jonathan Gibbons
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: jmx-dev RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Chris Plummer
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

jmx-dev RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Erik Joelsson
There are a number of files in the `test` directory that have an incorrect copyright header, which includes the "classpath" exception text. This patch removes that text from all test files that I could find it in. I did this using a combination of `sed` and `grep`. Reviewing this patch is probab

Re: jmx-dev RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-09-05 Thread Mark Sheppard
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: jmx-dev RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-09-05 Thread Roger Riggs
On Mon, 4 Sep 2023 11:01:23 GMT, Leo Korinth wrote: > What do you prefer? Do you have a better alternative? Do someone still think > the current code is good? I think what we have today is inferior to all these > improvements, and I would like to make it harder to develop bad test ca The curre