Re: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions

2025-06-13 Thread Daniel D . Daugherty
On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy wrote: > JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574) > > c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the > corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_.hpp > files are

Re: jmx-dev RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name [v2]

2024-07-11 Thread Daniel D . Daugherty
On Thu, 11 Jul 2024 15:38:29 GMT, Kevin Walls wrote: >> Follow-on from JDK-8207908. >> >> Two tests are broken by that change: >> sun/management/jmxremote/startstop/JMXStartStopTest.java >> sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java >> >> These are additional tests w

Re: jmx-dev RFR: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use

2024-04-01 Thread Daniel D . Daugherty
On Mon, 1 Apr 2024 02:02:40 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the test > failure reported in https://bugs.openjdk.org/browse/JDK-8328273? > > As noted in that issue, the > `sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java` inter

Re: jmx-dev RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

Re: jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v5]

2023-05-08 Thread Daniel D . Daugherty
On Mon, 8 May 2023 02:13:14 GMT, David Holmes wrote: >> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8304074: [JMX] Add an approximation of total bytes allocated on the Java >> heap by the JVM > > src/hotspot/share/serv

Re: jmx-dev RFR: 8298173: GarbageCollectionNotificationContentTest test failed: no decrease in Eden usage

2022-12-08 Thread Daniel D . Daugherty
On Thu, 8 Dec 2022 11:55:20 GMT, Kevin Walls wrote: >> This bug appears to be a regression caused by the fix for: >> >> [JDK-8297247](https://bugs.openjdk.org/browse/JDK-8297247) Add >> GarbageCollectorMXBean for Remark and Cleanup pause time in G1 >> >> so I've bumped the priority from P4 ->

Re: jmx-dev RFR: 8298173: GarbageCollectionNotificationContentTest test failed: no decrease in Eden usage

2022-12-07 Thread Daniel D . Daugherty
On Wed, 7 Dec 2022 21:50:11 GMT, Kevin Walls wrote: > Test should not check that Eden has decreased in used size if the GCCause is > "No GC". > > These happen with the message "end of concurrent GC pause" which is logged by > the GCMemoryManager _conc_gc_memory_manager (in G1MonitoringSupport)

Re: jmx-dev RFR: 8298173: GarbageCollectionNotificationContentTest test failed: no decrease in Eden usage

2022-12-07 Thread Daniel D . Daugherty
On Wed, 7 Dec 2022 21:50:11 GMT, Kevin Walls wrote: > Test should not check that Eden has decreased in used size if the GCCause is > "No GC". > > These happen with the message "end of concurrent GC pause" which is logged by > the GCMemoryManager _conc_gc_memory_manager (in G1MonitoringSupport)