Re: jmx-dev RFR: 8362533: Tests sun/management/jmxremote/bootstrap/* duplicate VM flags [v2]

2025-07-31 Thread duke
On Thu, 31 Jul 2025 04:54:39 GMT, Lei Zhu wrote: >> Hi all, >> >> `ProcessTools.createTestJavaProcessBuilder(String... command)` will call >> `jdk.test.lib.Utils#getTestJavaOpts`, so remove the duplicate vm flags. >> Trivial fix. >> >> Thanks! > > Lei Zhu has updated the pull request incremen

Re: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions

2025-06-13 Thread duke
On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy wrote: > JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574) > > c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the > corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_.hpp > files are

Re: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v2]

2024-12-09 Thread duke
On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim wrote: >> The return value of Metrics#getCpuSetCpus may change over time, including >> from non-null to null across the two calls in this method. > > Fabian Meumertzheim has updated the pull request incrementally with one > additional commit

Re: jmx-dev RFR: 8335625: Update Javadoc for GetCpuLoad [v4]

2024-09-10 Thread duke
On Mon, 26 Aug 2024 13:54:36 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: jmx-dev RFR: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks [v2]

2024-07-03 Thread duke
On Thu, 17 Nov 2022 09:43:39 GMT, Poison wrote: >> As the title says, add the volatile modifier. > > Poison has updated the pull request incrementally with one additional commit > since the last revision: > > 8297173: usageTicks and totalTicks should be volatile @tianshuang Your change (at

Re: jmx-dev RFR: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks

2024-07-03 Thread duke
On Thu, 17 Nov 2022 06:28:37 GMT, Poison wrote: > As the title says, add the volatile modifier. @tianshuang Your change (at version dd4599661ab209ef1a77c36be066a2af61304156) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/11199#issuecom

jmx-dev Withdrawn: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-07-06 Thread duke
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

jmx-dev Withdrawn: JDK-8295756 Improve NonLocalRegistry Manual Test Process

2023-03-01 Thread duke
On Fri, 21 Oct 2022 21:45:30 GMT, Bill Huang wrote: > The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to i

jmx-dev Withdrawn: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2023-01-27 Thread duke
On Fri, 2 Dec 2022 16:42:57 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

jmx-dev Withdrawn: 8285149: Using HashMap.newHashMap to replace new HashMap(int)

2022-08-03 Thread duke
On Tue, 19 Apr 2022 17:44:10 GMT, XenoAmess wrote: > These are the changes that too many to be reviewed in 8186958, thus split > some of them out. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/8301