Re: [josm-dev] 2 more bug fixes in relation handling

2008-06-27 Thread Jo
Frederik Ramm schreef: > Hi. > > >>> two more fixes: >>> 701 [PATCH] Bug in relation handling splitting up ways >>> 637 [PATCH] JOSM allows duplicate members in relations >>> >>> These two are very annoying :-) >>> > > >> I second that! 637 made me pull my hair out a few times befor

Re: [josm-dev] 2 more bug fixes in relation handling

2008-06-27 Thread Frederik Ramm
Hi. > > two more fixes: > > 701 [PATCH] Bug in relation handling splitting up ways > > 637 [PATCH] JOSM allows duplicate members in relations > > > > These two are very annoying :-) > I second that! 637 made me pull my hair out a few times before I > understood what was going on and why I was

Re: [josm-dev] 2 more bug fixes in relation handling

2008-06-27 Thread Jo
Dirk Stöcker schreef: > Hello, > > two more fixes: > 701 [PATCH] Bug in relation handling splitting up ways > 637 [PATCH] JOSM allows duplicate members in relations > > These two are very annoying :-) > I second that! 637 made me pull my hair out a few times before I understood what was goi

[josm-dev] JOSM code quality

2008-06-27 Thread Dirk Stöcker
Hello, only to tell you (whoever feels responsible). JOSM code quality seems to be very good. I made 6 patches fixing problems I had and it took me about 2-10 minutes to find the correct code, 2-30 minutes to understand it and 10-20 minutes to fix the problem. That are really very good values,

Re: [josm-dev] Some bugfixes

2008-06-27 Thread Dirk Stöcker
On Fri, 27 Jun 2008, Christoph Eckert wrote: Maybe. But if we had the two way mechanism ("inline" translations as well as centralised i18n), we should ensure that no strings appear in the lang plugins that are already tranlated inline. No. Why. Strings can be in both sets. Double text is only

Re: [josm-dev] Some bugfixes

2008-06-27 Thread Christoph Eckert
Hi, > On Fri, 27 Jun 2008, Frederik Ramm wrote: > > I don't think *this* is the problem. The problem, in my view, is that > > if you use tr() to translate the presets, then every preset - and > > there are possibly many, presets are not a built-in thing, a > > preset .xml is more like a config fil

[josm-dev] 2 more bug fixes in relation handling

2008-06-27 Thread Dirk Stöcker
Hello, two more fixes: 701 [PATCH] Bug in relation handling splitting up ways 637 [PATCH] JOSM allows duplicate members in relations These two are very annoying :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing lis

Re: [josm-dev] Some bugfixes

2008-06-27 Thread Dirk Stöcker
On Fri, 27 Jun 2008, Frederik Ramm wrote: I don't think *this* is the problem. The problem, in my view, is that if you use tr() to translate the presets, then every preset - and there are possibly many, presets are not a built-in thing, a preset .xml is more like a config file! - would have to b

Re: [josm-dev] Some bugfixes

2008-06-27 Thread Frederik Ramm
Hi, >> This is commendable and I'm sorry that I don't currently get to look >> through trac very often. I have committed your patches apart from 960 >> which I think requires a bit of discussion; I don't think that the >> simple gettext method is quite ideal for i18n of presets - but I >> might