Re: [josm-dev] Localize new strings in my plugin

2009-04-22 Thread Dirk Stöcker
On Sat, 11 Apr 2009, Henrik Niehaus wrote: > I have a question concerning my openstreetbugs plugin. I have added new > strings and want to translate them. What do I have to do? The gettext > support for my plugin has been added by Dirk, I think, and I don't have > a clue how this works. This is d

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Lars Francke
> But honestly, what would you say from a user interface perspective; > should we try and keep changesets open? What JOSM currently does is open > changeset - upload - close, for each upoad action. Some people have a > habit of uploading once every five minutes and they are perhaps annoyed > to hav

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Pieren
On Wed, Apr 22, 2009 at 1:20 AM, Frederik Ramm wrote: > But honestly, what would you say from a user interface perspective; should > we try and keep changesets open? What JOSM currently does is open changeset What I would like to see is that JOSM works like a wiki : when I click on the upload but

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Frederik Ramm
Hi, Lars Francke wrote: > As the API allows to query for all open changesets by a given user > what I would like to see is an option on upload to append to any of my > open changesets Sounds like somewhat of a "power user feature" to me. I'd say if you want to work on different things at the sam

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 22, 2009 at 11:28 AM, Frederik Ramm wrote: > JOSM will not allow you to omit the comment, much as SVN doesn't allow > you to commit without a message. Meaningful comments are vital to the > usability of the whole changeset thing and while I can't (yet) force > people to enter something

Re: [josm-dev] Localize new strings in my plugin

2009-04-22 Thread Henrik Niehaus
Dirk Stöcker schrieb: > On Sat, 11 Apr 2009, Henrik Niehaus wrote: > >> I have a question concerning my openstreetbugs plugin. I have added new >> strings and want to translate them. What do I have to do? The gettext >> support for my plugin has been added by Dirk, I think, and I don't have >> a c

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Greg Troxel
I can see why some people would find the comment requirement annoying, but coming from using svn for source code it seems very natural to me. I added a bunch of nodes for shops in my town last night and had no trouble typing "add some stores in Lower Village, and move some" or something like that.

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Frederik Ramm
Hi, Ævar Arnfjörð Bjarmason wrote: > On Wed, Apr 22, 2009 at 11:28 AM, Frederik Ramm wrote: >> JOSM will not allow you to omit the comment, much as SVN doesn't allow >> you to commit without a message. Meaningful comments are vital to the >> usability of the whole changeset thing and while I can'

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Maarten Deen
Frederik Ramm wrote: > Hi, > > Ævar Arnfjörð Bjarmason wrote: >> Even if it's only "fuck you"? Because that's the sort of crap we'll >> get in the database because JOSM is forcing commit messages on people. > > Yes, if the user so dislikes being communicative then let him put "fuck > you" there

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Pieren
On Wed, Apr 22, 2009 at 1:56 PM, Frederik Ramm wrote: > Yes, if the user so dislikes being communicative then let him put "fuck > you" there and be surprised why his edits get reverted more often than > others. > > Honestly, the commit comment is important and if someone who has made an > effort t

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Frederik Ramm
Hi, Maarten Deen wrote: > If a user gets his changes reverted more often because of the message he > writes, than I think the system is wrong, not the message. Edits should be > judged on the edit, not on the message that accompanies it. I could very well imagine having edits which are questionab

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Frederik Ramm
Hi, Pieren wrote: > If I have to choose, I prefere contributors making good quality > editions with no comments than contributors making bad quality stuff > with nice comments. Yes but why would you have to choose. Someone who values OSM high enough to devote time and quality work to it can be e

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 22, 2009 at 1:33 PM, Frederik Ramm wrote: > I am surprised that it requires explanation. Can you imagine the > usefulness of http://www.openstreetmap.org/browse/changesets without > descriptions? Nobody is arguing that detailed commit messages are a bad idea, but that undescriptive br

Re: [josm-dev] Commit message not empty

2009-04-22 Thread David Earl
On 22/04/2009 14:44, Ævar Arnfjörð Bjarmason wrote: > On Wed, Apr 22, 2009 at 1:33 PM, Frederik Ramm wrote: >> I am surprised that it requires explanation. Can you imagine the >> usefulness of http://www.openstreetmap.org/browse/changesets without >> descriptions? > > Nobody is arguing that detai

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Russ Nelson
Pieren writes: > like to describe my changes but not always. But when I see that "I > have to" do it, it makes me so angry that I write anything excepted > what I could kindly write otherwise. Does it make you angry that you have to click in the Upload button to commit your changes? OSM has be

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Ulf Lamping
Frederik Ramm schrieb: > > Yes but why would you have to choose. Someone who values OSM high enough > to devote time and quality work to it can be expected to describe in a > few words what he is uploading. Why would he say no? The value of the > contribution is so much higher if others can, in

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Martijn van Oosterhout
On Wed, Apr 22, 2009 at 10:54 PM, Ulf Lamping wrote: > But, what puzzles me most (if I understand it correct) is that only JOSM > has this policy. If it's such a vital interest to the probject, why > doesn't the API forces the comments? It's really strange if you add > something in Potlatch you *c

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Ulf Lamping
Martijn van Oosterhout schrieb: > On Wed, Apr 22, 2009 at 10:54 PM, Ulf Lamping > wrote: >> But, what puzzles me most (if I understand it correct) is that only JOSM >> has this policy. If it's such a vital interest to the probject, why >> doesn't the API forces the comments? It's really strange if

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Ulf Lamping
Frederik Ramm schrieb: > Hi, > > Ulf Lamping wrote: >> My fear is that especially newbies are prevented from uploading stuff: >> "what do I have to add here?!?" - please remember: not everyone has >> several years of subversion or wikipedia experience. > > We'll add a help button to explain. M

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Frederik Ramm
Hi, Ulf Lamping wrote: >>> My fear is that especially newbies are prevented from uploading >>> stuff: "what do I have to add here?!?" - please remember: not >>> everyone has several years of subversion or wikipedia experience. >> >> We'll add a help button to explain. > > Making the GUI complic

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Karl Guggisberg
Hi, > Uncommented changes are worth less than those with comments. Let's combine our efforts to make it as easy and comfortable for everyone to add > meaningful comments, and we all gain from it. Here's a possible patch: http://josm.openstreetmap.de/ticket/2442 It still enforces a commit commen

Re: [josm-dev] Commit message not empty

2009-04-22 Thread Ulf Lamping
Frederik Ramm schrieb: >> Making the GUI complicated and adding a Help button to explain the >> complications is, well, not the best idea for improved user >> friendliness IMHO. > > A text field where you have to enter text is not a complicated element. I perfectly agree, that there's no need