Re: [josm-dev] Critical bug since 2204

2009-10-05 Thread Frederik Ramm
Hi, Dieter Muecke wrote: > Running unit tests should be compulsory with every code check-in. > We should also consider to force having unit tests for all new added > packages! -1 Bye Frederik ___ josm-dev mailing list josm-dev@openstreetmap.org http

Re: [josm-dev] Critical bug since 2204

2009-10-05 Thread Dieter Muecke
Running unit tests should be compulsory with every code check-in. We should also consider to force having unit tests for all new added packages! Kind Regards, Dieter On 6 Oct 2009, at 00:15, Karl Guggisberg wrote: > Hi everybody > > since 2204 there was a critical bug in Way. It broke the

Re: [josm-dev] Critical bug since 2204

2009-10-05 Thread Pieren
On Tue, Oct 6, 2009 at 12:15 AM, Karl Guggisberg wrote: > It is still present in tested (2221) and users will certainly notice because > conflicts on ways are not detected > as expected. I tried on my build version and merging ways seems to work. Which type of conflicts are not detected ? Pieren

[josm-dev] Critical bug since 2204

2009-10-05 Thread Karl Guggisberg
Hi everybody since 2204 there was a critical bug in Way. It broke the merge logic (the unit tests for MergeVisitor didn't pass). It is still present in tested (2221) and users will certainly notice because conflicts on ways are not detected as expected. Shouldn't running all unit tests be part

Re: [josm-dev] JOSM Tested

2009-10-05 Thread Petr DlouhĂ˝
On Sat, 03 Oct 2009 11:53:10 +0200, Karl Guggisberg wrote: >> I was hoping to be developing over the weekend. I'm going to add >> referrers > (so you can eg get list of ways that reference >> some node). That should make some parts of josm much faster when working > with large datasets. > Great

Re: [josm-dev] Problem with referrers

2009-10-05 Thread Karl Guggisberg
Hi there, > jiri wrote: > I'm not talking about history, I've just mentioned few cases where JOSM use copies of primitives. I think, framm got confused. > framm wrote: > you're trying to keep a "breadcrumb" trail of what happened to an object, I hope not! (although, this is the way the undo/redo

Re: [josm-dev] Problem with referrers

2009-10-05 Thread Frederik Ramm
Hi, Jiri Klement wrote: > OsmPrimitive is no longer just a storage for osm data. It has (will > have) methods that will automatically update referrers, spatial index > and other things. We need another class that will just hold data - > that's what PrimitivePrototype is for. Is the "traditional"

Re: [josm-dev] Windows installer link: "Forbidden"

2009-10-05 Thread Dirk Stöcker
On Mon, 5 Oct 2009, Ulf Lamping wrote: > Just tried to download the JOSM Windows Installer[1] as linked from [2], > but only get a "fobidden" page. > > Should I write a ticket or will this be fixed soon? Please file a bug report. Building failed and until wednesday I have no time to fix it. I c

Re: [josm-dev] Problem with referrers

2009-10-05 Thread Frederik Ramm
Jiri, Jiri Klement wrote: > I'm working on support for referrers and I run into a problem which > I'm not sure how to fix. Can you explain (or point me to a previous post that explains) what referrers are good for? > Currently JOSM quite often makes copies of > primitive (using for example clon