Re: [josm-dev] Spaghetti code

2009-02-05 Thread Raphael Mack
Hi, I think I should also tell my story, since it somehow fits into this dicussion. Let me first say, that I really like Frederiks pragmatism. - History has shown, that the approach works and JOSM is a really useful tool. I have seen, that JOSM development is open for new ideas and new styles. T

Re: [josm-dev] Spaghetti code

2009-02-05 Thread Łukasz Jernaś
On Thu, Feb 5, 2009 at 1:36 AM, Frederik Ramm wrote: > (And you will also re-compile all > plugins afterwards and see if they still compile ;-) Ah, that reminds me of the buildbot I should have set up ;) -- Łukasz ___ josm-dev mailing list josm-dev@o

Re: [josm-dev] Spaghetti code

2009-02-05 Thread GeoJ
Stefan Breunig wrote: > If classes need fixing, why not just add a new one > "classThatNeedsFixing2" with a proper implementation. Change JOSM to > use "2" in various places, let it bake and see if it needs any > additional feature and mark the old class as depricated and advise > develops to use "

Re: [josm-dev] Spaghetti code

2009-02-05 Thread Stefan Breunig
If classes need fixing, why not just add a new one "classThatNeedsFixing2" with a proper implementation. Change JOSM to use "2" in various places, let it bake and see if it needs any additional feature and mark the old class as depricated and advise develops to use "2" instead. That way all new dev

Re: [josm-dev] Spaghetti code

2009-02-04 Thread Igor Shubovych
Ok. Sorry for that flame. Regards, Igor Shubovych 2009/2/5 Frederik Ramm > Hi, > > Igor Shubovych wrote: > >> But what about small refactoring steps. Step by step the code better. >> As I see it is histrorical problem, you didn't want to broke the plugins. >> > > There is absolutely nothing to

Re: [josm-dev] Spaghetti code

2009-02-04 Thread Frederik Ramm
Hi, Igor Shubovych wrote: > But what about small refactoring steps. Step by step the code better. > As I see it is histrorical problem, you didn't want to broke the plugins. There is absolutely nothing to say against stepwise improvement! If someone says "I need to change this because otherwise

Re: [josm-dev] Spaghetti code

2009-02-04 Thread Igor Shubovych
2009/2/5 Frederik Ramm > Igor, > > Igor Shubovych wrote: > >> I really do not want to abuse anybody, but ... this is spaghetti code. >> > > We don't have GOTOs though. > > I suggest you read, and try to understand, the discussion that begins with > this message: > > http://lists.openstreetmap.o

Re: [josm-dev] Spaghetti code

2009-02-04 Thread Igor Shubovych
2009/2/5 Stephan > Igor Shubovych wrote: > >> I really do not want to abuse anybody, but ... this is spaghetti code. >> ...Almost everywhere in JOSM. >> > > > Quote from wiki (imi): > http://josm.openstreetmap.de/wiki/DevelopingPlugins > > First some words about my style of accessing public varia

Re: [josm-dev] Spaghetti code

2009-02-04 Thread Frederik Ramm
Igor, Igor Shubovych wrote: > I really do not want to abuse anybody, but ... this is spaghetti code. We don't have GOTOs though. I suggest you read, and try to understand, the discussion that begins with this message: http://lists.openstreetmap.org/pipermail/josm-dev/2008-August/001433.html T

Re: [josm-dev] Spaghetti code

2009-02-04 Thread Stephan
Igor Shubovych wrote: > I really do not want to abuse anybody, but ... this is spaghetti code. > ...Almost everywhere in JOSM. Quote from wiki (imi): http://josm.openstreetmap.de/wiki/DevelopingPlugins First some words about my style of accessing public variables. Most people find this annoying

[josm-dev] Spaghetti code

2009-02-04 Thread Igor Shubovych
Ladies and gentlemen, I really do not want to abuse anybody, but ... this is spaghetti code. ...Almost everywhere in JOSM. Most fields which represents GUI components (labels, text fields buttons) in panels and dialogs are public or have package visibility level. E.g. public class PleaseWaitDialo

[josm-dev] Spaghetti code

2009-02-04 Thread Igor Shubovych
Ladies and gentlemen, I really do not want to abuse anybody, but ... this is spaghetti code. ...Almost everywhere in JOSM. Most fields which represents GUI components (labels, text fields buttons) in panels and dialogs are public or have package visibility level. E.g. public class PleaseWaitDialo