[jquery-dev] bug in 1.3.3pre version of attr()

2009-07-10 Thread David Flanagan
The 1.3.3pre version of the attr() method doesn't handle object arguments where property values are functions in the same way that 1.3.2 does (and the way that the docs say it should). I think because in the code reorganization the jQuery.prop() helper function went away. I believe that a very

[jquery-dev] Proposal: Display CSS property shouldn't always set to Block

2009-07-10 Thread James An
The display CSS property is always set to Block when invoking show() or when the element's dimensions are changed (i.e. by setting height or width, or by using a show effect like slideDown). Instead of always settings display to Block to show the element, I'm proposing that display be set to the

[jquery-dev] Re: Enhancement to the trim method

2009-07-10 Thread Daniel Friesen
FF3.5's native (ie: likely faster than any js based trim) only trims whitespace. So personally, I think that if we wanted a function to trim specific characters it should be implemented in a separate function, like a "strip". That's basically how I did it in Wrench.js

[jquery-dev] Re: Enhancement to the trim method

2009-07-10 Thread Klaus Hartl
On 10 Jul., 16:13, dotnetCarpenter wrote: > About jQuery size, this won't add much to the size as regex /\s+/g is > already used in the core and could be replaced with a call to trim > (String, true), which would actually improve code coverage. I haven't > looked into the jQuery UI source but I b

[jquery-dev] Re: Enhancement to the trim method

2009-07-10 Thread dotnetCarpenter
Interesting.. I think the question is; if we extend the core methods do we add to the overall size of websites using jQuery or do we reduce it? If developers add the same functionality all the time in different projects, then a generic trim method would actually insure best practice (performance,

[jquery-dev] Re: Enhancement to the trim method

2009-07-10 Thread dotnetCarpenter
About jQuery size, this won't add much to the size as regex /\s+/g is already used in the core and could be replaced with a call to trim (String, true), which would actually improve code coverage. I haven't looked into the jQuery UI source but I bet it's there as well. You have a good point about

[jquery-dev] Re: Enhancement to the trim method

2009-07-10 Thread Andrea Giammarchi
try to include the trim from php.js then since php has that option as extra argument: http://uk3.php.net/manual/en/function.trim.php On Fri, Jul 10, 2009 at 9:04 AM, George wrote: > > Yep, I'm inclined to agree that trim() is for trimming! > > The only little

[jquery-dev] Re: Enhancement to the trim method

2009-07-10 Thread George
Yep, I'm inclined to agree that trim() is for trimming! The only little enhancement that I and several colleagues have often considered is the ability to specify what character to trim off. (The default being space of course) George On Jul 9, 8:34 pm, Daniel Friesen wrote: > Ya, I see no reaso