[jquery-dev] Re: Binding to events in child iframe windows

2009-02-27 Thread Diego Perini
Jed, it seems the first error you mentioned is now OK in all browser I could test. In Internet Explorer 6 I still see the second error I said above in line 958 char 6 error: Invalid argument. But this is a different issue, your patch seems to have corrected the logic error, hope somebody from th

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-27 Thread Jed Schmidt
Diego, Thanks for taking a look. I've distilled the test case down to make it simpler: http://s3.amazonaws.com/iframeWindowTest/before.html http://s3.amazonaws.com/iframeWindowTest/after.html And submitted a bug here: http://dev.jquery.com/ticket/4268 Jed Schmidt On Feb 27, 7:26 am, Diego Pe

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-27 Thread Diego Perini
Jed, now your test is accessible, I can load it. One problem I noticed: frameWindow.onresize = function( e ) { $("") .text( "DOM " + e.type + " event on the " + this.name + " at " + +new Date ) .prependTo( frameWindow.document.body ); } when using DOM0 events IE will not pass

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-26 Thread Jed Schmidt
Diego, My apologies, I misunderstood you. (Also, the test case is working now: resize the window to test it, and see that jQuery is binding one of the resize events incorrectly.) Jed Schmidt On Feb 26, 6:01 pm, Diego Perini wrote: > Jed, > your test case is not accessible for me. I get "Acces

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-26 Thread Diego Perini
Jed, your test case is not accessible for me. I get "Access denied". Diego On 27 Feb, 02:21, Jed Schmidt wrote: > The above code is just to skip processing for text nodes (nodeType == > 3) and comments (nodeType == 8), which do not have events. > > Windows are the only elements which lack a no

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-26 Thread Diego Perini
Jed, I am not trying to understand what they meant when they wrote this, it is clear enough. I share and agree with your other points above, I was just saying that testing: elem.nodeType == 3 || elem.nodeType == 8 when "elem" is a window reference, I expected to fail, but actually it does no

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-26 Thread Jed Schmidt
The above code is just to skip processing for text nodes (nodeType == 3) and comments (nodeType == 8), which do not have events. Windows are the only elements which lack a nodeType, but for which events (resize, focus) are possible. Here's a better test case: http://s3.amazonaws.com/iframeWindow

[jquery-dev] Re: Binding to events in child iframe windows

2009-02-26 Thread Diego Perini
Jed, I would like to add that a few lines above the ones you pointed out we also have: if ( elem.nodeType == 3 || elem.nodeType == 8 ) return; Can "elem" really be a window/frame reference ? Shouldn't this give an error since windows/frames do not have a