[jquery-dev] Re: Ticket #4087 (1.3 regression due to documentFragment)

2009-03-02 Thread Diego Perini
Dave, I didn't meant changing anything there...maybe I optimized too much. What I wanted to do was just adding a ".cloneNode(false)" in the second "fragment" instance in that line so instead of: callback.call( root(this[i], first), this.length > 1 || i > 0 ? fragment.cloneNode(true) : fr

[jquery-dev] Re: Ticket #4087 (1.3 regression due to documentFragment)

2009-03-01 Thread Dave Methvin
Diego, that patch makes the error go away because the selected node now has a parentNode, but it's the wrong parentNode--it's the document fragment instead of the original document. So, the element gets left behind in the document fragment instead of being inserted back into the document. It loo

[jquery-dev] Re: Ticket #4087 (1.3 regression due to documentFragment)

2009-02-28 Thread Diego Perini
John, could you have a look if this change could fit in domManip() ? callback.call( root(this[i], first), fragment.cloneNode(this.length > 1 || i > 0) ); it seems solving the reported errors: uncaught exception: Node cannot be inserted at the specified point in the hierarchy (NS_ERROR_DOM_

[jquery-dev] Re: Ticket #4087 (1.3 regression due to documentFragment)

2009-02-28 Thread John Resig
Actually, that might not be too bad - we would just check to see if one of the appending nodes exists in the set - and just not move it, if that's the case. I'll check in to it. --John On Sat, Feb 28, 2009 at 3:20 PM, Dave Methvin wrote: > > This looks like a difficult one to fix: > > http://