[jquery-dev] typo in ready event since null !== undefined

2009-11-17 Thread Andrea Giammarchi
AFAIK top window frameElement returns null and not undefined, as is for document.body when not present yet. Moreover we can use the JavaScript weird case where null == undefined but while null is static, undefined can be redefined or in any case it needs to be discovered in the scope chain. On

Re: [jquery-dev] typo in ready event since null !== undefined

2009-11-17 Thread John Resig
Good suggestion, just landed it: http://github.com/jquery/jquery/commit/3a23a5c17dd0522da06db8f36890f134f9004de6 You should mention stuff like this as comments on the commits - and file follow-up patches through Github. It makes it super-easy to manage (on my end, at least). --John On Tue, Nov

Re: [jquery-dev] typo in ready event since null !== undefined

2009-11-17 Thread Andrea Giammarchi
John I am not that familiar with github yet, I did a mess wven with last PureDom for taskspeed so please forgive me ... but there is another problem there, if I am not wrong. Line 826 of the same file: // Catch cases where $(document).ready() is called after the // browser event

Re: [jquery-dev] typo in ready event since null !== undefined

2009-11-17 Thread John Resig
That line is intentional. It's for cases where jQuery is being dynamically loaded and you wish to execute the ready event immediately. **We make no guarantees about this happening in all the browsers that we support.** (Namely this is because of the problem that you mentioned in Firefox 3.6.) As

Re: [jquery-dev] typo in ready event since null !== undefined

2009-11-17 Thread John Resig
Oh, just to mention, regarding your solution snippet - it doesn't really solve anything (especially not for us). The case that we're looking to handle with the readyState code was when jQuery is loaded after the document ready event has already occurred. Your snippet will be stuck in a permanent