Thanks everyone for the incredible feedback, this is way greater than I had
ever hoped for! I'm sorry I haven't the time right now to respond to each of
you individually, but I have been working on some of the changes that have
been proposed and am just trying to track down a little bug before I pu
On 7 January 2011 20:31, Nick Fitzgerald wrote:
> Hello everyone!
> Noodles 277 lines long, but with over 100 lines of comments I hope I'm not
> asking for too much when requesting code review :)
> Its pretty well known in the JS circle that if you are iterating over a
> really big list and doing
Hi Nick,
One more thing, I would add is to create a separate
function reduce (items, iterFn, callback, initial) {
//...
}
noodles.reduce = reduce;
And then you wont have to write out noodles.reduce in every function,
just reduce. That would make it a "bit" faster, and more compressible.
--
P
On Sat, Jan 8, 2011 at 11:36 PM, Nicholas C. Zakas
wrote:
> Hi Nick,
>
> I took a quick look at your code. Your comments already point out a few
> things you want to fix, so I’ve not mentioned any of those. My comments are:
>
Thank you for taking your time to do this!
>
> 1. Lines 34 and 36 c
ent: Friday, January 07, 2011 12:31 PM
To: jsmentors@googlegroups.com
Subject: [JSMentors] Request for code review: noodles - Async/non-blocking/CPS
versions of the higher order functions on `Array.prototype`
Hello everyone!
Noodles 277 lines long, but with over 100 lines of comments I hope I&#x
Hello everyone!
Noodles 277 lines long, but with over 100 lines of comments I hope I'm not
asking for too much when requesting code review :)
Its pretty well known in the JS circle that if you are iterating over a
really big list and doing a fairly expensive operation on each iteration,
you can b
