[Jsynthlib-devel] SVN and code reviews

2009-01-15 Thread William R. Zwicky
I'm in the area too, though I'm hiding so noone makes me do any work. =^p On the migration to SVN: Please do! I believe SVN is the recommended repo at SourceForge anyway. If you're running Windows, I highly recommend TortoiseSVN (as does SourceForge) over the command-line client. Tortoise h

Re: [Jsynthlib-devel] XioSynth patch editor, 2nd try

2009-01-15 Thread Joe Emenaker
Rib Rdb wrote: > I'd recommend migrating to svn so we could use > http://codereview.appspot.com One advantage of SVN is that it supports *moving* of files to different directories. Long ago, in a galaxy far away, we had talked about refactoring all of the core JSL code into a more-sensible pack

Re: [Jsynthlib-devel] XioSynth patch editor, 2nd try

2009-01-15 Thread denis queffeulou
I don't know if my opinion counts but we at work have migrate to SVN too. It takes a little time to adapt usage from CVS but it works well finally, especially with folders manipulation. It's important to have conventions (or follow usual conventions) because it's a bit "generic" with not much con

Re: [Jsynthlib-devel] XioSynth patch editor, 2nd try

2009-01-15 Thread Nicolas Boulicault
Hi, I attached a new version of xiosynth driver and modifications. As stated in my first post, I'd like someone who knows the core better than me to check the modification in BankEditorFrame.java. diff and tar were started from JSynthLib directory. I don't know about the code reviews. (I'll che

Re: [Jsynthlib-devel] XioSynth patch editor, 2nd try

2009-01-15 Thread Rib Rdb
I am also alive. Before adding you as a developer I'd like to code review at least your first commit. Can you send a patch to the list? On a related note, if this project because active again I think it would be a good idea to make code reviews standard for all commits. I've gotten used to using

Re: [Jsynthlib-devel] XioSynth patch editor, 2nd try

2009-01-15 Thread Nicolas Boulicault
Hi Joe, thanks for your reply. Indeed I've been working with the current cvs version, and I don't think my code breaks anything. It would be fine for me if you added me to the developers. I'm already an admin on a few sourceforge projects, I wouldn't mind becoming one on JSynthLib too. Anyway I'm