Good day,
I tested, reviewed and discussed the following *rabbitmq-server* charm
proposal with peers.
While the Ubuntu OpenStack Engineering team supports the essence of this
proposal as a more secure default stance for the charm to take, and the
impact of the default change has been assessed as
Yesterday during my review queue time, I revisited a MP[1] I had worked on the
previous week. With the information provided by gnuoy, I was able to fully test
the rabbitmq-server against bug #1355848[2] and I am happy to report that the
bug is fixed by this MP and have approved it.
[1]https://
[1] Merge proposal for rabbitmq-server. The author has been attentive to
feedback, and his latest work passes charm proof and lint cleanly. I’ve asked
him to provide the steps necessary to properly test his changes, in lieu of
actual unit tests.
[2] Pinged #juju on Freenode for a charmer to m
# TL;DR for Charm Authors (tips from today's reviews)
1. Make sure charm-proof, "testing" make targets (e.g. lint, test), and
amulet tests are passing. We are quickly approaching a day when all merge
proposals for charms and bundles will be gated on tests automatically, and
rejected if they fail.
