https://code.launchpad.net/~tribaal/charms/precise/storage/refactor-mount-volume/+merge/232236
Needs Fixing: Failing some deployments scenerios, but the idea and
refactor seem sound at this point. Spoke with Chris in the review and
on IRC.
--
David Britton
--
Juju mailing list
Juju@lists.
I reviewed Chris's addition to the storage charm to add encrypted
file-system support. He added tests per Tim's request, which were
good, but I had issues running them as we as encountering a few small
test breakages in the existing tests.
I also reviewed Matt's test additions to get the nfs char
https://code.launchpad.net/~tribaal/charms/precise/storage/refactor-mount-volume/+merge/232236
I had some back-and-forth discussion with Chris and David regarding
this refactor, which looks like a great change to me. I have
personally reserved my +1 due to some tests that were necessarily
removed
Heya,
Thanks a lot for your feedback (and David's as well, of course).
It's hard to get these big refactorings right without having more eyes
on the code, so thanks a lot for helping with fleshing it out :)
I think the way forward for this branch is: renaming the
"storage-providers.d" folder to
On Fri, Sep 26, 2014 at 09:46:44PM +0300, Christopher Glass wrote:
>
> Back to the hammer and anvil for this one!
Looking forward to seeing it again. Thanks Chris for your willingness
to take this one on! :)
--
David Britton
--
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or uns
