Re: [ANN] juju-core 1.13.2 has been released

2013-08-26 Thread James Page
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 25/08/13 13:17, David Cheney wrote: Thanks John. James -- I have uploaded the release tarball now, sorry about the delay, I was in an airplane. No problem; juju-core 1.13.2 also uploaded to Saucy. Cheers James - -- James Page Ubuntu and

api.Client().ServiceGet() and int types

2013-08-26 Thread John Arbash Meinel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm implementing juju get via the API. In doing so, I moved over one of our tests which did (pseudocode) set value=int64(0) DeepEquals(result, value) And it used to work when ServiceGet was connecting directly to State. Now that it goes via the

Re: [ANN] juju-core 1.13.2 has been released

2013-08-26 Thread Antonio Rosales
James, Thanks for uploading to Saucy. Julian/David, I see the fix is committed We'll need to cut another release this week for any remaining Azure fixes in preparation for the announcement next week. David, could you confirm with Julian on when is the correct time to cut another devel release?

Re: Policies for coding

2013-08-26 Thread Tim Penhey
On 23/08/13 21:37, roger peppe wrote: On 23 August 2013 04:11, Tim Penhey tim.pen...@canonical.com wrote: // TODO (thumper): 2013-08-23 bug 1654321 // Details about the change needed, or things to do. This seems reasonable, but there's one down side - currently for most TODOs, a grep will

Clean Code and single character variable names

2013-08-26 Thread Tim Penhey
Hi all, If you haven't yet, please get a copy of Clean Code [1] as we will be starting reviews of it soon. I have found a reference in that book that pretty clearly describes my dislike for single character variable names. I type that section here. Avoid Mental Mapping [2] Readers shouldn't

Re: Null provider and failing early

2013-08-26 Thread Andrew Wilkins
On Tue, Aug 27, 2013 at 8:44 AM, Tim Penhey tim.pen...@canonical.comwrote: Perhaps we should have a sanity-check type callback into the provider with the constraints at the time we want to add a machine. This would give the null provider the early fail mechanism, and could also allow other

Re: Clean Code and single character variable names

2013-08-26 Thread Nate Finch
I don't have time to properly respond, but I'm pretty sure no one on this team is using single letter variables to save keystrokes. Is is a good point that abbreviations may be more common in one area than another. I find both ctx and txn to be completely self explanatory even with zero context

Re: Null provider and failing early

2013-08-26 Thread Tim Penhey
On 27/08/13 11:50, Andrew Wilkins wrote: On Tue, Aug 27, 2013 at 8:44 AM, Tim Penhey tim.pen...@canonical.com mailto:tim.pen...@canonical.com wrote: Perhaps we should have a sanity-check type callback into the provider with the constraints at the time we want to add a machine. This

Re: Null provider and failing early

2013-08-26 Thread David Cheney
I think they should be ignored, but preserved. On Tue, Aug 27, 2013 at 11:40 AM, Tim Penhey tim.pen...@canonical.com wrote: On 27/08/13 11:50, Andrew Wilkins wrote: On Tue, Aug 27, 2013 at 8:44 AM, Tim Penhey tim.pen...@canonical.com mailto:tim.pen...@canonical.com wrote: Perhaps we

Re: Policies for coding

2013-08-26 Thread Tim Penhey
On 27/08/13 15:30, Gustavo Niemeyer wrote: On Mon, Aug 26, 2013 at 11:50 PM, Tim Penhey tim.pen...@canonical.com wrote: On 27/08/13 14:33, Gustavo Niemeyer wrote: On Mon, Aug 26, 2013 at 8:03 PM, Tim Penhey tim.pen...@canonical.com wrote: Information hiding and abstracting implementation