Re: Preferred wrapping for long function declarations

2014-05-14 Thread John Meinel
I've personally found it quite edifying to see what William and Nate like, and while I don't think we should enforce a One True Way, I have tweaked my own preferences a bit from the discussion. Somewhere between 3 an William's 3. I don't really prefer Nate's 3 because the args aren't wrapped the

Re: Preferred wrapping for long function declarations

2014-05-14 Thread Frank Mueller
Sure, I like the discussion too and it has been interesting to see what gofmt thankfully else accepts There have been some formats I never tried before. mue On Wed, May 14, 2014 at 9:53 AM, John Meinel j...@arbash-meinel.com wrote: I've personally found it quite edifying to see what William

Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo)

2014-05-14 Thread Tim Penhey
Hi all, I took it upon myself to get Rog's errgo library used inside juju-core. Dimiter recently did a hunk of work in the juju-core/errors package to have functions to add context to some core error types while keeping their type. What I did was to move this errors package out of juju-core and

Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo)

2014-05-14 Thread John Meinel
I'd like gccgo to pass reliably, but I think it falls under a CI test rather than a pre-commit test. (Because otherwise it roughly doubles the time it takes to know whether your patch will land.) I don't have specific feedback on the behavior differences, but the changes seem sane to me. An

Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo)

2014-05-14 Thread Curtis Hovey-Canonical
On Wed, May 14, 2014 at 8:12 AM, John Meinel j...@arbash-meinel.com wrote: I'd like gccgo to pass reliably, but I think it falls under a CI test rather than a pre-commit test. (Because otherwise it roughly doubles the time it takes to know whether your patch will land.) I agree. We can setup

Actions

2014-05-14 Thread Mike Sam
I know juju run is out but I am wondering when we should expect Actions that do not require ssh access to the machines? Also, will actions allow arbitrary (defined at runtime) hook code or show the code be part of the charm already? Thanks, Mike -- Juju-dev mailing list

Filing SRU's

2014-05-14 Thread Adam Stokes
Just to get some clarification -- are we handling juju updates within the archive through the normal SRU processes? It was mentioned that there may be an exception for juju-core but wanted to make sure before I go through with patching the existing package (1.18.1 at the time of this writing).

Re: Actions

2014-05-14 Thread John Weldon
We're working on Actions ... it's going in fits and starts. We've got a lot to learn (and appreciate all the time and attention from all of you experienced juju devs) We were thinking maybe by the middle of June, but we've been over-optimistic in the past. Hopefully soon! irc: jcw4, bodie_,