Re: utils/fslock needs to DIAF

2015-12-01 Thread roger peppe
So I'm with axw on this one - flock seems like it is a reasonable tool for the job here. FWIW a Unix domain socket also suffers from the "won't work across NFS" problem. Abstract unix domain sockets also have the problem that they won't work with long file paths (what were they thinking?) We have

Re: utils/fslock needs to DIAF

2015-12-01 Thread William Reade
Fully agree that fslock is terrible, but strongly against spending significant engineering effort on it: AFAIAA, core won't need it any more when we've integrated the agents, and that work is progressing nicely. Given that, do we *really* need the os-agnostic abstraction we're discussing? Cheers W

Re: utils/fslock needs to DIAF

2015-12-01 Thread roger peppe
On 1 December 2015 at 10:25, William Reade wrote: > Fully agree that fslock is terrible, but strongly against spending > significant engineering effort on it: AFAIAA, core won't need it any more > when we've integrated the agents, and that work is progressing nicely. Given > that, do we *really* n

Re: utils/fslock needs to DIAF

2015-12-01 Thread David Cheney
On Tue, Dec 1, 2015 at 8:10 PM, roger peppe wrote: > So I'm with axw on this one - flock seems like it is a reasonable tool for > the job here. FWIW a Unix domain socket also suffers from the "won't > work across NFS" problem. Abstract unix domain sockets also > have the problem that they won't wo

Re: utils/fslock needs to DIAF

2015-12-01 Thread roger peppe
On 1 December 2015 at 12:34, David Cheney wrote: > On Tue, Dec 1, 2015 at 8:10 PM, roger peppe wrote: >> So I'm with axw on this one - flock seems like it is a reasonable tool for >> the job here. FWIW a Unix domain socket also suffers from the "won't >> work across NFS" problem. Abstract unix do

Re: utils/fslock needs to DIAF

2015-12-01 Thread Nate Finch
I think half the problem is that someone named the package fslock and not oslock, so we're stuck asking the wrong question. If the question is "How do I acquire an OS-level lock for a process?" The answer on Windows is "Use a named mutex". Dave seems to be saying that the only problem with unix

Re: utils/fslock needs to DIAF

2015-12-01 Thread roger peppe
On 1 December 2015 at 16:43, Nate Finch wrote: > I think half the problem is that someone named the package fslock and not > oslock, so we're stuck asking the wrong question. > > If the question is "How do I acquire an OS-level lock for a process?" The > answer on Windows is "Use a named mutex".

Re: utils/fslock needs to DIAF

2015-12-01 Thread Nate Finch
Certainly using Windows' file system lock is appropriate for locking its files. I thought the case we were talking about was just abusing that ability as a generic cross-process lock. I wasn't aware of how configstore was using fslock. On Tue, Dec 1, 2015 at 11:58 AM roger peppe wrote: > On 1