Re: apiserver authorizers

2015-12-03 Thread William Reade
Thanks for asking :). Not sure there's a document directly focused on it, largely because it's relatively simple -- doc/design/ juju-api-design-specification.md just says: > The authorizer represents a value that can be asked for authorization > information on its associated authenticated entity.

Re: apiserver authorizers

2015-12-03 Thread William Reade
(it's not quite done, but that's in the nature of wikis, and I have to EOD sharpish today...) On Thu, Dec 3, 2015 at 5:54 PM, William Reade wrote: > Thanks for asking :). Not sure there's a document directly focused on it, > largely because it's relatively simple -- doc/design/ > juju-api-design

Be very careful in assumptions in tests

2015-12-03 Thread Tim Penhey
Hi folks, I came across an interesting bug yesterday and during investigation found that there was a very comprehensive test that covered the situation. The problem is that the asserts were not actually running. The asserts were inside a loop where the expectation was that the loop would run exa

Re: Be very careful in assumptions in tests

2015-12-03 Thread Nate Finch
I'll definitely +1 the need for gc.HasLen ... I've seen a ton of panics in tests if the code starts erroneously returning nil slices. Obviously this is less bad, since the tests still fail, but they're really ugly annoying failures. And +1000 to making tests that fail before fixing the code (or a