So, two things: 1.) We don't need to worry about this anymore, since I've removed the need for the generated code. But to clarify, I was using stringer ( https://github.com/golang/tools/blob/master/cmd/stringer/stringer.go) which generates files with String() methods for enums. 2.) There's like 1000 go generate tools to embed files as resources in Go code... we should probably just use one of those, rather than rolling our own. (for example, many of them gzip the contents to make them smaller, etc).
On Thu, Jan 7, 2016 at 3:12 AM Ian Booth <ian.bo...@canonical.com> wrote: > We're already using go generate in the cloud-credentials feature branch. > And the > code we generate has the correct header. > > We have a top level generate package into which it is intended various > generators will live. > > Here's a generator which reads the contents of a file and assigns that to > a Go > constant. > > https://github.com/juju/juju/blob/cloud-credentials/generate/filetoconst.go > > > > On 07/01/16 17:47, Andrew McDermott wrote: > > Can the "thing" that is generating the content not add the header? > > > > On 6 January 2016 at 22:18, Katherine Cox-Buday < > > katherine.cox-bu...@canonical.com> wrote: > > > >> Nate ran into an interesting problem yesterday. If we begin to use go > >> generate directives to auto-generate code, do we care that this code > >> doesn't have a Copyright header? We check the generated file into source > >> control, but as the file is meant to be regenerated in the event of a > >> change, we don't want to edit it by hand to add the header. > >> > >> -- > >> - > >> Katherine > >> > >> > >> -- > >> Juju-dev mailing list > >> Juju-dev@lists.ubuntu.com > >> Modify settings or unsubscribe at: > >> https://lists.ubuntu.com/mailman/listinfo/juju-dev > >> > > > > > > > > > > > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev >
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
